Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es_objects plugin fixes #808

Open
1 of 3 tasks
oxarbitrage opened this issue Apr 3, 2018 · 4 comments
Open
1 of 3 tasks

es_objects plugin fixes #808

oxarbitrage opened this issue Apr 3, 2018 · 4 comments

Comments

@oxarbitrage
Copy link
Member

oxarbitrage commented Apr 3, 2018

while writing documentation to the plugin: https://github.com/oxarbitrage/worker-proposals/blob/master/es_objects.md

i found 3 points that need attention and fixes:

  • Balance tracking, change to account_balance.
  • Limit order tracking, when the limit order is created and filled in the same block the original limit order will not be saved. Generally, if an object is updated and then deleted in a block, data in ES is not updated (if we don't delete it).
  • Feed tracking, several feeds coming in the same second.

ill take care of them.

@oxarbitrage
Copy link
Member Author

change in balance tracking was done here #1271

@oxarbitrage
Copy link
Member Author

I think this issue should remain open even if #1271 was merged. The reason is that not all the items in the issue were addressed by the pull. I am moving this to the next milestone.

@abitmore
Copy link
Member

Moved to next milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants