Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue1013, New API: get transaction hex without signatures field #1038

Merged
merged 2 commits into from
Jun 12, 2018
Merged

Issue1013, New API: get transaction hex without signatures field #1038

merged 2 commits into from
Jun 12, 2018

Conversation

cryptocifer
Copy link
Member

fix #1013

@ryanRfox ryanRfox added 1c Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks 3c Enhancement Classification indicating a change to the functionality of the existing imlementation 2g Final Review Status indicating the solution passes the test case(s) and is being reviewed for final acceptance. labels Jun 11, 2018
@ryanRfox ryanRfox added this to In Testing in Community Claims Jun 11, 2018
oxarbitrage
oxarbitrage reviewed Jun 11, 2018
View reviewed changes
libraries/app/include/graphene/app/database_api.hpp Outdated
/// signatures-stripped transaction
std::string
get_transaction_hex_without_sig(const signed_transaction &trx) const;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please put std::string and get_transaction_hex_without_sig(const signed_transaction &trx) const; in the same line. thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am wondering also what will be happening if a transaction with signatures came here. what will be the output ? maybe add a test case for that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 please add a test case.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alfredo and Peter, fixed

oxarbitrage
oxarbitrage approved these changes Jun 12, 2018
View reviewed changes
Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks.

@oxarbitrage oxarbitrage merged commit 46929a5 into bitshares:develop Jun 12, 2018
@oxarbitrage oxarbitrage mentioned this pull request Jun 12, 2018
Closed
6 tasks
@ryanRfox ryanRfox moved this from In Testing to Ready for Integration in Community Claims Jun 14, 2018
@ryanRfox ryanRfox added 2h Accepted Status indicating the solution passed final review, and is ready for implementation and removed 2g Final Review Status indicating the solution passes the test case(s) and is being reviewed for final acceptance. labels Jun 14, 2018
@abitmore abitmore added this to In Development in Feature Release (201808) via automation Jul 21, 2018
@abitmore abitmore moved this from In Development to Done in Feature Release (201808) Jul 21, 2018
@abitmore abitmore mentioned this pull request Aug 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmconrad pmconrad pmconrad approved these changes

@oxarbitrage oxarbitrage oxarbitrage approved these changes

Assignees
No one assigned
Labels
1c Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks 2h Accepted Status indicating the solution passed final review, and is ready for implementation 3c Enhancement Classification indicating a change to the functionality of the existing imlementation
Projects
No open projects
Community Claims
  
Ready for Integration
Feature Release (201808)
  
Done
Milestone
201808 - Non-Consensus-Changing Release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cryptocifer @pmconrad @oxarbitrage @abitmore @ryanRfox