Warning and Infotext Fixes #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmjatlanta
approved these changes
Aug 26, 2019
abitmore
added this to In development
in Protocol Upgrade Release (5.0.0)
via automation
abitmore
reviewed
Aug 26, 2019
| @@ -117,7 +117,7 @@ asset cdd_vesting_policy::get_allowed_withdraw(const vesting_policy_context& ctx | |||
| return asset(0, ctx.balance.asset_id); | |||
| fc::uint128_t cs_earned = compute_coin_seconds_earned(ctx); | |||
| fc::uint128_t withdraw_available = cs_earned / std::max(vesting_seconds, 1u); | |||
| assert(withdraw_available <= ctx.balance.amount.value); | |||
| assert(withdraw_available <= static_cast<fc::uint128_t>(ctx.balance.amount.value)); | |||
There was a problem hiding this comment.
This assert only works for debug build. I guess we want to remove it or change it to FC_ASSERT, but it belongs to a new PR (see #511).
pmconrad
modified the milestones:
4.1.0 - Feature Release,
4.0.0 - Protocol Upgrade Release
pmconrad
added this to In development
in Protocol Upgrade Release (4.0.0)
via automation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Monkeys!
Just purging two compiler warnings and fixing one incorrect test info message.
Ape out!