Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump FC for Reflection/static_variant updates #1968

Merged
merged 5 commits into from Sep 3, 2019

Conversation

nathanielhourt
Copy link
Contributor

This bumps FC to HEAD of master, adding support for the new reflection information and updated static_variant which now has a working operator== and no longer has a default operator<.

Ref bitshares/bitshares-fc#156 & bitshares/bitshares-fc#154

@nathanielhourt
Copy link
Contributor Author

sigh Now holding for bitshares/bitshares-fc#158

@abitmore abitmore added this to In development in Protocol Upgrade Release (5.0.0) via automation Sep 3, 2019
@abitmore abitmore added this to the 4.1.0 - Feature Release milestone Sep 3, 2019
Copy link
Contributor

@jmjatlanta jmjatlanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Tested on Ubuntu 16.04 / Boost 1.69. chain_test runs with no errors detected.

Protocol Upgrade Release (5.0.0) automation moved this from In development to In testing Sep 3, 2019
@nathanielhourt nathanielhourt merged commit 0f8b7b1 into bitshares:develop Sep 3, 2019
Protocol Upgrade Release (5.0.0) automation moved this from In testing to Done Sep 3, 2019
@nathanielhourt nathanielhourt deleted the reflection-updates branch September 3, 2019 23:33
@pmconrad pmconrad added this to In development in Protocol Upgrade Release (4.0.0) via automation Oct 15, 2019
@pmconrad pmconrad moved this from In development to Done in Protocol Upgrade Release (4.0.0) Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants