Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move stuff into namespaces #1992

Merged
merged 3 commits into from Sep 20, 2019
Merged

Move stuff into namespaces #1992

merged 3 commits into from Sep 20, 2019

Conversation

pmconrad
Copy link
Contributor

@pmconrad pmconrad commented Sep 16, 2019 •
edited

Fixes #1895
Requires fc bump for bitshares/bitshares-fc#164

@pmconrad pmconrad added this to In development in Protocol Upgrade Release (5.0.0) via automation Sep 16, 2019
@pmconrad pmconrad added this to the 4.1.0 - Feature Release milestone Sep 16, 2019
@pmconrad
Copy link
Contributor Author

Bumped fc, this includes

@pmconrad pmconrad marked this pull request as ready for review September 19, 2019 14:40
@pmconrad
Copy link
Contributor Author

Rebased to resolve conflict.

abitmore
abitmore approved these changes Sep 19, 2019
View reviewed changes
Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

Protocol Upgrade Release (5.0.0) automation moved this from In development to In testing Sep 19, 2019
@abitmore abitmore mentioned this pull request Sep 19, 2019
Merged
@pmconrad pmconrad merged commit 991bd75 into bitshares:develop Sep 20, 2019
Protocol Upgrade Release (5.0.0) automation moved this from In testing to Done Sep 20, 2019
@pmconrad pmconrad deleted the 1895_namespaces branch September 20, 2019 06:03
This was referenced Sep 20, 2019
Closed
Closed
Closed
@ryanRfox ryanRfox added this to In development in Protocol Upgrade Release (4.0.0) via automation Oct 15, 2019
@ryanRfox ryanRfox moved this from In development to Done in Protocol Upgrade Release (4.0.0) Oct 15, 2019
@MichelSantos MichelSantos mentioned this pull request Oct 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abitmore abitmore abitmore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Protocol Upgrade Release (4.0.0)
  
Done
Milestone
4.0.0 - Protocol Upgrade Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pmconrad @abitmore @ryanRfox