Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2P improvement: periodically re-check addresses of seed nodes #2164

Merged
merged 2 commits into from May 3, 2020

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Apr 29, 2020

For issue #2153.

Ready for review.

  • The first commit contains a code refactory and a small fix ported from Add P2P security options #1764, in order to mitigate potential conflicts when merging Add P2P security options #1764 in the future. Note that it also moves the logging about seed nodes from default to p2p, thus future issues about seed nodes (unable to resolve and etc) will be less visible for node admins.
  • The second commit contains code for checking seed nodes updates.

Code ported from #1764 .
The code also fixes a race condition on node startup caused by the premature `connect_to_endpoint` call.
@abitmore abitmore added this to In development in Protocol Upgrade Release (4.0.0) via automation Apr 29, 2020
@abitmore abitmore changed the title P2P improvements P2P improvement: periodically re-check addresses of seed nodes May 1, 2020
@abitmore abitmore marked this pull request as ready for review May 1, 2020 13:48
@abitmore abitmore moved this from In development to In testing in Protocol Upgrade Release (4.0.0) May 1, 2020
@abitmore abitmore merged commit ecc5cbb into hardfork May 3, 2020
Protocol Upgrade Release (4.0.0) automation moved this from In testing to Done May 3, 2020
@abitmore abitmore deleted the pr-2153-recheck-seeds branch May 3, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants