added api function get_account_history_operations #237
Conversation
| { | ||
| FC_ASSERT( _app.chain_database() ); | ||
| const auto& db = *_app.chain_database(); | ||
| FC_ASSERT( limit <= 100 ); |
There was a problem hiding this comment.
if you move the assertion by -1 line .. you can spare instanciating the database if the limit is to high :D
There was a problem hiding this comment.
i kind of agree wityh this however that part of the code is an exact copy of get_account_history.
|
This PR looks good to me, however, I don't know enough of the database defaults to be 100% sure this code does what it does. |
|
To add to xeroc's comment, I'm also concerned about performance. Anyone able to comment on that aspect? |
|
in regards to database defaults with stop, limit for a possible segfault. The function in that aspect is a copy of get_account_history. |
|
This is effectively a line-by-line copy of |
No description provided.