Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix object slicing warnings, duplicate code and some other code smells #2372

Merged
merged 14 commits into from Mar 7, 2021
Merged

Fix object slicing warnings, duplicate code and some other code smells #2372

merged 14 commits into from Mar 7, 2021

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Mar 6, 2021 •
edited

For #2101.

@abitmore abitmore added this to the 5.2.0 - Feature Release milestone Mar 6, 2021
@abitmore abitmore added this to In development in Feature Release (5.2.0) via automation Mar 6, 2021
@abitmore abitmore changed the title Fix object slicing warnings Fix object slicing warnings, duplicate code and some other code smells Mar 6, 2021
@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

95.8% 95.8% Coverage
0.8% 0.8% Duplication

@abitmore abitmore merged commit fc59463 into develop Mar 7, 2021
Feature Release (5.2.0) automation moved this from In development to Done Mar 7, 2021
@abitmore abitmore deleted the fix-object-slicing branch March 7, 2021 18:25
@abitmore abitmore mentioned this pull request Apr 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Feature Release (5.2.0)
  
Done
Milestone
5.2.0 - Feature Release
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@abitmore