Fix liquidity pool deposit statistics #2471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abitmore
added
the
6 API
abitmore
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
abitmore
modified the milestones:
5.3.0 - Feature Release,
6.0.0 - Protocol Upgrade Release
abitmore
added this to In Development
in Protocol Upgrade Release (6.0.0)
via automation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following data in liquidity pool statistics was incorrect:
_24h_deposit_amount_a_24h_deposit_amount_b_24h_balance_delta_a_24h_balance_delta_btotal_deposit_amount_atotal_deposit_amount_bThis PR fixes it.
The first commit is to reproduce the issue (see also https://github.com/abitmore/bitshares-core/actions/runs/925545407), the second commit is the fix.
The fix requires a chain replay.