Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for MPA owners to disable collateral bidding #2504

Merged
merged 5 commits into from
Oct 5, 2021
Merged

Add option for MPA owners to disable collateral bidding #2504

merged 5 commits into from
Oct 5, 2021

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Oct 4, 2021

PR for #2281.

Add new option for MPA owners to disable collateral bidding.

Specifications:

  • new disable_collateral_bidding bit in asset flags and issuers_permissions
    • unable to set before hard fork
    • unable to set on UIAs, but can be set on PMs (although useless)
    • common logic about issuer permissions (if permission is forfeited, unable to update flag, unable to enable permission if supply is non-zero, etc)
  • if set in flags, unable to bid collateral
  • when newly configured via asset_update_operation, cancel all collateral bids
  • at hard fork time, cancel all collateral bids of asset which already disabled collateral bidding (due to old bug)

@abitmore abitmore added this to In Development in Protocol Upgrade Release (6.0.0) via automation Oct 4, 2021
@abitmore abitmore linked an issue Oct 4, 2021 that may be closed by this pull request
Add option for MPA owners to disable collateral bidding #2281
Closed
17 tasks
@abitmore abitmore moved this from In Development to In Testing in Protocol Upgrade Release (6.0.0) Oct 4, 2021
@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@abitmore abitmore merged commit b252597 into hardfork Oct 5, 2021
Protocol Upgrade Release (6.0.0) automation moved this from In Testing to Done Oct 5, 2021
@abitmore abitmore deleted the pr-2281-disable-collateral-bidding branch October 5, 2021 17:50
This was referenced Oct 5, 2021
Closed
Closed
@abitmore abitmore mentioned this pull request Nov 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hardfork
Projects
No open projects
Protocol Upgrade Release (6.0.0)
  
Done
Milestone
6.0.0 - Protocol Upgrade Release
Development

Successfully merging this pull request may close these issues.

Add option for MPA owners to disable collateral bidding
1 participant
@abitmore