Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix liquidity pool history APIs #2517

Merged
merged 2 commits into from
Oct 20, 2021
Merged

Fix liquidity pool history APIs #2517

merged 2 commits into from
Oct 20, 2021

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Oct 20, 2021

There were 2 issues:

  • according to documentation, records at time equals to stop should not be included in result
  • unexpected data may be returned when stop is later than start

There were 2 issues:
- stop should not be included in result according to documentation
- unexpected data may be returned when stop is behind start
@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@abitmore abitmore merged commit e0b3e97 into hardfork Oct 20, 2021
Protocol Upgrade Release (6.0.0) automation moved this from In Development to Done Oct 20, 2021
@abitmore abitmore deleted the fix-liquidity-pool-api branch October 20, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant