Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code smells #2705

Merged
merged 1 commit into from Dec 6, 2022
Merged

Fix code smells #2705

merged 1 commit into from Dec 6, 2022

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Dec 5, 2022

Note: this is identical to #2703, recreated to get around a permission issue related to the sonar-scan Github Actions workflow.

rewind is reserved
prefix increment dropped_count, i, next_block_num for efficiency increment from method call fetch_by_number() could cause undefined behavior parenthesis added for explicit operator precedence order of operations clarified
max 1 nested break

@litepresence
delinting
95c5a53 
`rewind` is reserved
prefix increment `dropped_count, i, next_block_num` for efficiency
increment from method call `fetch_by_number()`  could cause undefined behavior
parenthesis added for explicit operator precedence 
order of operations clarified
max 1 nested break
@abitmore abitmore added this to the 6.2.0 - Feature Release milestone Dec 5, 2022
@abitmore abitmore added this to In development in Feature Release (7.1.0) via automation Dec 5, 2022
This was referenced Dec 5, 2022
Closed
Merged
@sonarcloud
Copy link

sonarcloud bot commented Dec 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

60.0% 60.0% Coverage
0.0% 0.0% Duplication

@abitmore abitmore merged commit d3b18fe into develop Dec 6, 2022
Feature Release (7.1.0) automation moved this from In development to Done Dec 6, 2022
@abitmore abitmore deleted the litepresence-patch-1 branch December 6, 2022 08:18
@abitmore abitmore mentioned this pull request May 19, 2023
Closed
@abitmore abitmore removed this from Done in Feature Release (7.1.0) Sep 25, 2023
@abitmore abitmore added this to In progress in Protocol Upgrade Release (7.0.0) via automation Sep 25, 2023
@abitmore abitmore moved this from In progress to Done in Protocol Upgrade Release (7.0.0) Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Protocol Upgrade Release (7.0.0)
  
Done
Milestone
7.0.0 - Protocol Upgrade Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abitmore @litepresence