add get_top_markets #737
Merged
add get_top_markets #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abitmore
reviewed
Mar 16, 2018
libraries/app/database_api.cpp
Outdated
| vector<market_volume> result; | ||
|
|
||
| fc::uint128 base_volume; | ||
| fc::uint128 quote_volume; |
libraries/app/database_api.cpp
Outdated
| fc::uint128 base_volume; | ||
| fc::uint128 quote_volume; | ||
|
|
||
| uint c = 0; |
libraries/app/database_api.cpp
Outdated
| @@ -115,6 +115,7 @@ class database_api_impl : public std::enable_shared_from_this<database_api_impl> | |||
| market_ticker get_ticker( const string& base, const string& quote, bool skip_order_book = false )const; | |||
| market_volume get_24_volume( const string& base, const string& quote )const; | |||
| order_book get_order_book( const string& base, const string& quote, unsigned limit = 50 )const; | |||
| vector<market_volume> get_top_markets(uint limit)const; | |||
There was a problem hiding this comment.
Code style: add spaces.
By the way, I don't like uint, perhaps change to uint32_t?
|
cleaned that, thanks. |
abitmore
reviewed
Mar 17, 2018
libraries/app/database_api.cpp
Outdated
| mv.quote = assets[1]->symbol; | ||
| mv.base_volume = uint128_amount_to_string( itr->base_volume, assets[0]->precision ); | ||
| mv.quote_volume = uint128_amount_to_string( itr->quote_volume, assets[1]->precision ); | ||
| result.push_back(mv); |
There was a problem hiding this comment.
I think result.emplace_back( std::move(mv) ) would have better performance.
|
|
||
| const auto& volume_idx = _db.get_index_type<graphene::market_history::market_ticker_index>().indices().get<by_volume>(); | ||
| auto itr = volume_idx.rbegin(); | ||
| vector<market_volume> result; |
There was a problem hiding this comment.
Adding a result.reserve(limit); here would improve performance.
|
thank you, added the performance changes at eaefc59 |
abitmore
approved these changes
Mar 17, 2018
|
agree, added and merged. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #560
Edited by @abitmore: this is new PR for #512.