Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed busy-wait in delete_files #184

Merged
merged 1 commit into from Dec 11, 2019
Merged

Fixed busy-wait in delete_files #184

merged 1 commit into from Dec 11, 2019

Conversation

pmconrad
Copy link

@pmconrad pmconrad commented Dec 10, 2019 •
edited by abitmore

@pmconrad pmconrad mentioned this pull request Dec 10, 2019
Closed
17 tasks
@pmconrad pmconrad added this to the core release 4.0.0 milestone Dec 10, 2019
jmjatlanta
jmjatlanta approved these changes Dec 10, 2019
View reviewed changes
Copy link

@jmjatlanta jmjatlanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, nice work! Code looks concise, Compiled on Ubuntu 18.04, tests run fine.

abitmore
abitmore approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@pmconrad pmconrad merged commit 463380d into bitshares:for-core-4.0.x Dec 11, 2019
@pmconrad pmconrad deleted the 2078_file_appender branch December 11, 2019 06:38
@MichelSantos MichelSantos mentioned this pull request Dec 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmjatlanta jmjatlanta jmjatlanta approved these changes

@abitmore abitmore abitmore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
core release 4.0.0
3 participants
@pmconrad @jmjatlanta @abitmore