Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve safe<T> #248

Merged
merged 11 commits into from
Mar 29, 2023
Merged

Improve safe<T> #248

merged 11 commits into from
Mar 29, 2023

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Mar 26, 2023

PR for bitshares/bitshares-core#2147.

  • Improve safe<T>
    • support only integers, both signed and unsigned
    • check overflow and underflow on initialization
    • fix issues when T is unsigned
    • add tests
    • remove explicitly declared copy constructor, so that the compiler will implicitly declare copy constructors, move constructors, assignment operators, etc
  • Fix a cleanup issue in logging_tests
  • Update some CI configurations

@abitmore abitmore added this to the core release 6.2.0 milestone Mar 26, 2023
@abitmore abitmore force-pushed the improve-safe-t branch 2 times, most recently from a5bcc6c to 15d8282 Compare March 26, 2023 13:26
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

* support only integers, both signed and unsigned
* check overflow and underflow on initialization
* fix issues when T is unsigned
* add tests
* remove explicitly declared copy constructor, so that the compiler will
  implicitly declare copy constructors, move constructors, assignment
  operators, etc
for better coverage reporting, including branch coverage
@sonarcloud
Copy link

sonarcloud bot commented Mar 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

61.2% 61.2% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant