Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC logging level inconsistency #929 #62

Merged
merged 2 commits into from Jul 23, 2018

Conversation

4 participants
@cogutvalera
Copy link
Member

commented Jul 17, 2018

@cogutvalera cogutvalera referenced this pull request Jul 17, 2018

Closed

RPC logging level inconsistency #929

4 of 8 tasks complete
@abitmore
Copy link
Member

left a comment

Good job.

@cogutvalera

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2018

@abitmore Thank you very much !

@cogutvalera

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2018

should I close this pull request ? or not ?

@pmconrad
Copy link

left a comment

Also need to add this to websocket_tls_server_impl.
Please check for other places as well.

@pmconrad

This comment has been minimized.

Copy link

commented Jul 17, 2018

should I close this pull request ? or not ?

Just keep it open until we have merged it.

@cogutvalera

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2018

Just keep it open until we have merged it.

OK. Sure ! Thx !

Also need to add this to websocket_tls_server_impl.
Please check for other places as well.

OK. I will check.

@cogutvalera cogutvalera force-pushed the cogutvalera:valera_issue_929 branch from 8fe7931 to ee25279 Jul 17, 2018

@cogutvalera

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2018

@pmconrad I've added log for websocket_tls_server_impl but cannot find other places.

@cogutvalera

This comment has been minimized.

Copy link
Member Author

commented Jul 18, 2018

I don't see any other places for logs, is this issue finished or not yet ? Should I do any changes here or not ?

@nanomobile

This comment has been minimized.

Copy link

commented Jul 18, 2018

Thanks !

@cogutvalera cogutvalera changed the title fixed issue #929 RPC logging level inconsistency #929 Jul 21, 2018

@abitmore abitmore merged commit ed168a4 into bitshares:master Jul 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.