Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.5] Portfolio table's MPA settle flag assumes backing is BTS (Typo) #1707

Closed
grctest opened this issue Jul 18, 2018 · 1 comment
Closed

[0.5] Portfolio table's MPA settle flag assumes backing is BTS (Typo) #1707

grctest opened this issue Jul 18, 2018 · 1 comment
Assignees
@startailcoon
Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design
Milestone
180801

Comments

@grctest
Copy link
Contributor

grctest commented Jul 18, 2018 •
edited
Loading

Describe the bug
Within the dashboard (portfolio) page, the table rows with MPA assets have a settle flag which states that the MPA can be settled for BTS, however it does not replace the 'BTS' text with the MPA's actual backing asset.

To Reproduce
Steps to reproduce the behavior:

  1. Go to dashboard portfolio page.
  2. Have an entry for any MPA.
  3. Hover over the settle MPA flat
  4. See text error

Expected behavior
The tooltip should inform the user of the actual backing asset they will receive.

Screenshots

image

NOTE: Actual backing asset was 'TEST', not BTS.

Desktop (please complete the following information):

  • OS: Windows
  • Browser Chrome
  • Version Latest

Additional context
Only a minor text error, however it could mislead MPA holders of the real contents of held MPA.
@startailcoon startailcoon self-assigned this Jul 22, 2018
@startailcoon startailcoon added the [3] Bug Classification indicating the existing implementation does not match the intention of the design label Jul 22, 2018
@startailcoon startailcoon added this to the 180803 milestone Jul 22, 2018
@startailcoon startailcoon changed the title Portfolio table's MPA settle flag assumes backing is BTS (Typo) [0.5] Portfolio table's MPA settle flag assumes backing is BTS (Typo) Jul 22, 2018
@startailcoon
Copy link
Contributor

The UI had no translation for another backing asset, and BTS was a fixed value.

bitXCD is backed by bitUSD and is properly displayed now.

bitshares-backingassetsettle

@startailcoon startailcoon mentioned this issue Jul 22, 2018
Merged
svk31 pushed a commit that referenced this issue Aug 21, 2018
@startailcoon @svk31
Fix #1707 - "Settle Backing Asset" Translation Issue (#1716)
008cd33 
* Settle Backing Asset properly displayed
- Removes hardcoded value 'BTS'

* Prepend bit to bitAssets on Settling Tooltip

* Fix bitAsset prepend on settle tooltip

* Dynamic settle delay on settle tooltip
@snyk-bot snyk-bot mentioned this issue Mar 31, 2021
Open
@snyk-bot snyk-bot mentioned this issue Aug 23, 2021
Open
@AndreiShybin AndreiShybin mentioned this issue Jan 9, 2023
Open
@AndreiShybin AndreiShybin mentioned this issue Nov 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@startailcoon startailcoon

Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design
Projects
None yet
Milestone
180801
Development

No branches or pull requests
2 participants
@startailcoon @grctest