Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.5] Add Ability to Invert the Call Price Ratio For Borrowed Assets #204

Closed
landry314 opened this issue Jul 22, 2017 · 13 comments
Closed
Assignees
Labels
[3] Feature Classification indicating the addition of novel functionality to the design
Milestone

Comments

@landry314
Copy link

landry314 commented Jul 22, 2017

Under ACCOUNT tab under Margin Positions I see:

x bitCNY y BTS RATIO (CALL PRICE) BTS/bitCNY

but I would rather it was:

x bitCNY y BTS RATIO (CALL PRICE) bitCNY/BTS

You have the ratio flipped the least useful way.

(EDITED AFTER ERROR I MADE)

@landry314 landry314 changed the title Call Price Pair Label Flipped Call Price Pair Label Ratio Flipped Jul 22, 2017
@wmbutler
Copy link
Contributor

Needs to be researched and once confirmed, we can classify it as a bug.

@landry314
Copy link
Author

landry314 commented Jul 23, 2017

Ok, this isn't a bug, it is just that the call price is written in the less useful ratio.

It would be nice to be able to invert the price like you can in the recent activity.

@landry314
Copy link
Author

landry314 commented Jul 28, 2017

The ratios are also inverted in the recent activity feed. Can't you see this? LOOK. This is an incredible mistake.

I absolutely astonished the developers don't care about a mistake like this.

@wmbutler
Copy link
Contributor

Man, I've got to say, your tone sucks. We are all here to help so try not to be so condescending, please.

@svk31
Copy link
Contributor

svk31 commented Jul 30, 2017

Agree with Bill about the tone.

On the issue itself, your missing the fact that there is no "right" way of displaying prices, you may prefer one market direction while I prefer the other. In the recent activity feed you can click the price and invert it so it uses the direction you prefer. We could certainly enable that for the call prices as well.

@landry314
Copy link
Author

I apologize about my tone. I appreciate all the work you have done.

I agree that adding INVERT THE PRICE for the Call Price would be a good feature to please everyone.

@wmbutler wmbutler added [3] Feature Classification indicating the addition of novel functionality to the design and removed question labels Aug 7, 2017
@wmbutler wmbutler added this to the 170914 milestone Aug 7, 2017
@landry314 landry314 changed the title Call Price Pair Label Ratio Flipped Add Ability to Invert the Call Price Ratio For Borrowed Assets Aug 9, 2017
@wmbutler
Copy link
Contributor

Could use some help estimating this @svk31

@svk31 svk31 self-assigned this Aug 31, 2017
@wmbutler
Copy link
Contributor

wmbutler commented Sep 1, 2017

I think we need to adopt an icon for price inversion across the entire site. Ideally, clicking on an asset would take the user to the asset explorer page, while clicking on an inversion icon would invert the price and clicking on a a market/exchange icon would take them to the exchange. We are currently trying to pack too much functionality into the display of a trading pair.

@wmbutler wmbutler changed the title Add Ability to Invert the Call Price Ratio For Borrowed Assets [1] Add Ability to Invert the Call Price Ratio For Borrowed Assets Sep 1, 2017
@wmbutler
Copy link
Contributor

wmbutler commented Sep 1, 2017

Short term fix (before tables rewrite): Add text above "Update Position" titled "Invert Price"

screen shot 2017-09-01 at 10 35 50 am

@landry314
Copy link
Author

Maybe "Invert Pair" or "Flip Ratio" or "Invert Ratio" might work too. "Invert Price" to me feels like an action you might be doing to your position when next to two other position actions.

@wmbutler
Copy link
Contributor

wmbutler commented Sep 4, 2017

"Invert pair"

@svk31
Copy link
Contributor

svk31 commented Sep 5, 2017

Or we could just revert it to the old behaviour which is like this:

image

@svk31 svk31 changed the title [1] Add Ability to Invert the Call Price Ratio For Borrowed Assets [0.5] Add Ability to Invert the Call Price Ratio For Borrowed Assets Sep 5, 2017
@svk31 svk31 closed this as completed Sep 5, 2017
@landry314
Copy link
Author

landry314 commented Sep 19, 2017

One other place we can't invert the ratio is after clicking "See open orders" from the leftmost menu under ACCOUNT tab. I have to use a calculator to invert it sometimes. I'll create a new issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[3] Feature Classification indicating the addition of novel functionality to the design
Projects
None yet
Development

No branches or pull requests

3 participants