Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1] Smartcoin flag re-enables itself after cancelled 'save changes' login prompt? #2043

Closed
grctest opened this issue Oct 22, 2018 · 8 comments
Assignees
Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design [7] Finalized Administartion flag, notifies hours are finalized
Milestone

Comments

@grctest
Copy link
Contributor

grctest commented Oct 22, 2018

Describe the bug
I attempted to permanently disable the "Allow issuer to force a global settling" permission within Hertz, but after completing the saved changes I noticed that the flag was still enabled..

I attempted the change again, and it re-enabled itself!

To Reproduce
Steps to reproduce the behavior:

  1. Go to a bitasset's update page.
  2. Go to the permissions.
  3. Disable the "Allow issuer to force a global settling" permission.
  4. Hit "Save Changes"
  5. Cancel the password prompt.
  6. Observe a ghost re-enabling the permission!

Expected behavior
The flag does not self-configure itself.

Screenshots

Desktop (please complete the following information):

  • OS: Windows
  • Browser: N/A - light client
  • Version 180926

Additional context

Hopefully the reverse doesn't occur to someone..

@grctest
Copy link
Contributor Author

grctest commented Oct 22, 2018

Just attempted to disable this setting with the latest client release, paid the fee, tx '1.11.534986968' and it re-enabled itself after confirming the changes... Is this because the supply is greater than 0? I'd have expected a warning if that was the case.

@HarukaMa
Copy link
Contributor

Maybe clicking save triggered UI refresh even though the wallet is not unlocked?

@grctest
Copy link
Contributor Author

grctest commented Oct 23, 2018

I attempted the change again, I first fully unlocked my wallet, changed a price feed publisher and attempted to permanently disable the flag, the transaction confirmation included the changes, I paid the fee and the flag re-enabled itself after confirmation.

@abitmore
Copy link
Member

"the flag re-enabled itself" is just a UI display issue, right?

@clockworkgr
Copy link
Member

"the flag re-enabled itself" is just a UI display issue, right?

i'd seriously hope so

@grctest
Copy link
Contributor Author

grctest commented Oct 24, 2018

@abitmore I've not attempted to remove the permission via the CLI or using a python script, solely using the Bitshares UI. I'm unable to remove the permission in the UI after multiple attempts.

@grctest
Copy link
Contributor Author

grctest commented Jan 4, 2019

Anyone experiencing this issue could workaround this by burning the asset-owner permissions, creating the same effect - effectively permanently disabling the "Allow issuer to force a global settling" permissions as there'd be no issuer capable of forcing the global settlement.

@sschiessl-bcp sschiessl-bcp self-assigned this Jan 23, 2019
@sschiessl-bcp sschiessl-bcp added the [3] Bug Classification indicating the existing implementation does not match the intention of the design label Jan 28, 2019
@sschiessl-bcp sschiessl-bcp added this to the 190103 milestone Jan 28, 2019
@sschiessl-bcp
Copy link
Contributor

There was a bug in asset_utils that the flag global_settle was always set in UI.

sschiessl-bcp pushed a commit that referenced this issue Jan 28, 2019
…re-enables_itself

#2043 smartcoin flag re enables itself
@sschiessl-bcp sschiessl-bcp added the [7] Estimated Administration flag, notifies hours are estimated and requires revisiting label Jan 28, 2019
@startailcoon startailcoon changed the title Smartcoin flag re-enables itself after cancelled 'save changes' login prompt? [1] Smartcoin flag re-enables itself after cancelled 'save changes' login prompt? Feb 12, 2019
@startailcoon startailcoon added [7] Finalized Administartion flag, notifies hours are finalized and removed [7] Estimated Administration flag, notifies hours are estimated and requires revisiting labels Feb 12, 2019
@startailcoon startailcoon modified the milestones: 190103, 190117, 190131 Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design [7] Finalized Administartion flag, notifies hours are finalized
Projects
None yet
Development

No branches or pull requests

6 participants