Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First Wallet Has to Be Named "default" #208

Closed
landry314 opened this issue Jul 24, 2017 · 9 comments
Closed

First Wallet Has to Be Named "default" #208

landry314 opened this issue Jul 24, 2017 · 9 comments
Labels
[3] Enhancement Classification indicating a change to the functionality of the existing imlementation

Comments

@landry314
Copy link

When creating the first wallet in the light wallet program you HAVE to call it "default". This is annoying.

I simply created another wallet with a name I wanted then deleted the "default" wallet and everything is fine. There is nothing "default" about it, JUST FIRST, which is bad programming because its name implies something about it which isn't true, nothing defaults to it for any reason.

Many people therefore will have the same name in their wallet backup file which could potentially cause confusion if there are many from different times and devices, etc., that have collected together for some reason.

Just let us name the first wallet whatever we want, please!

@wmbutler
Copy link
Contributor

Can you submit some screenshots or a video of the process you are referring to? Thanks!

@landry314
Copy link
Author

Steps to reproduce:

  1. Go to https://bitshares.openledger.info/create-account/wallet
  2. Click on Settings cog
  3. Click on Wallet
  4. You see no active wallet
  5. Click on New Wallet
  6. You are not given the option to name the wallet
  7. The wallet created has the name "default"
  8. Click on New Wallet again
  9. Name the new wallet whatever you like

You must create the wallet named "default" before you can create a new wallet named what you like then you can delete the default wallet. If there is no wallet yet, it does not allow you to name it what you like.

@landry314
Copy link
Author

no wallet yet
no wallet name choice

@landry314
Copy link
Author

landry314 commented Jul 24, 2017

And I just found another bug with the default wallet name...

I just did a clean install of my light wallet then restored the backup I just made. Guess what? My wallet is now called "dafault"! The restore feature just ignored the name of the wallet and called it "default". This is probably because it is the first wallet in this instance of the program...

The wallet management just loves to name the first wallet default when it is creating one and when it is restoring one. In the code this is probably the exact same fix... somewhere the name "default" is being forced on a wallet if there are no wallets present.

@wmbutler
Copy link
Contributor

Thanks!

@wmbutler wmbutler added [3] Feature Classification indicating the addition of novel functionality to the design [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive and removed question labels Jul 26, 2017
@Ashaman-
Copy link
Contributor

I think the wallet name should default to something, rather than be an extra blank for the user to fill in during account creation. Defaulting it to the name of the first account registered instead of 'default' would make a lot of sense.

@abitmore
Copy link
Member

From the steps we know this is for advanced users. I don't think this is high priority.

@wmbutler wmbutler removed the [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive label Aug 17, 2017
@wmbutler wmbutler added [3] Enhancement Classification indicating a change to the functionality of the existing imlementation and removed [3] Feature Classification indicating the addition of novel functionality to the design labels Sep 13, 2017
@wmbutler
Copy link
Contributor

I'm closing this for now. It's such a fringe request.

@landry314
Copy link
Author

Fair enough, but then I will create a new issue for the restoring bug mentioned on July 24 in this thread. When you restore a wallet, it changes the name to default and forgets whatever custom name you had... it is a related bug and probably has the same core reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[3] Enhancement Classification indicating a change to the functionality of the existing imlementation
Projects
None yet
Development

No branches or pull requests

4 participants