[4.5][nikandrovalex][2][gibbsfromncis] AddonBefore & AddonAfter for StyleGuide Inputs #2101
Assignees
Labels
[1b] User Story
The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s)
[3] Refactoring
Classification indicating a change to code refactoring.
[5c] Medium
Indicates size of task. Est. between two and four hours
[6] Style Guide
Impact flag identifying related to a Style Guide
[7] Finalized
Administartion flag, notifies hours are finalized
Milestone
Comments
|
@sschiessl-bcp one thought - update it. I'll take care about this. |
|
@nikandrovalex Please based in our style-guide inputs provide nice design for Pre/Post tabs for Inputs (https://ant.design/components/input/#components-input-demo-addon) for all 3 themes |
gibbsfromncis
changed the title
startailcoon
added
[1b] User Story
startailcoon
changed the title
|
I'm guilty for this as I wasn't fully knowing the guidelines of the style-guide back when I re-made this and used the ANT components. I've made a few bad overrides to make it look good based on the designs, which wasn't fully compatible with the provided UX. I'm putthing this in the capable hands of @gibbsfromncis and added an estimated hour to look over this. |
|
@gibbsfromncis this one is 17 days since claimed. Thoughts? |
|
@wmbutler Waiting for UX... UPD: Forgot to assign @nikandrovalex ... |
Does this need much UX? Put the AssetSelect component as addon? |
|
@sschiessl-bcp not much. I'll propose my options and ask @nikandrovalex for his agreement |
startailcoon
added
[6] Style Guide
startailcoon
changed the title
|
@sschiessl-bcp please check |
|
@sschiessl-bcp I spent 4 hours and 38 minutes on this task. There was a lot of incomprehensible, but @gibbsfromncis helped me, thanks) |
|
@nikandrovalex about estimates ping @startailcoon @startailcoon added .5h for a call to sync with Alex |
gibbsfromncis
changed the title
startailcoon
changed the title
startailcoon
added
[7] Finalized
gibbsfromncis
added a commit
to gibbsfromncis/bitshares-ui
that referenced
this issue
Dec 10, 2018
gibbsfromncis
changed the title
|
Added hours for time I spent for development |
sschiessl-bcp
pushed a commit
that referenced
this issue
Dec 12, 2018
#2101 Update style-guide version to the latest
manikey123
added a commit
to manikey123/bitshares-ui
that referenced
this issue
Dec 23, 2018
* ANT AssetSelector replacement: add AssetInput and AssetSelect * AssetInput: don't show as invalid when there is no input * bug fix initialization on private testnets. * Implement Collateral Bid - New operations descriptions - New bid collateral form - New collateral bids table New AssetActions - bidCollateral() FormattedPrice Updated - negative_invert for price with a negative invert factor * Fixes * Fixes * Fixes * 2084 issue fix v3 * When this.props.result is undefine, give default value to resultCode"eAmount * When this.props.result is undefine, give default value to resultCode"eAmount * Sort by Issuer name * update * - included display of included bids and refined text Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * default sort is price Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * fix collateral valuation Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * fix implicit type covnversion Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * bitshares#2135 Update style-guide version. Add steps component support * refine text for bidding Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * enhance error handling of node (url not found) Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * enhance error handling of node (url not found) Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * Closes bitshares#1826 - allow AccessSettings to be rendered without a connected node - balance can have undefiend entries Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * remove unused import Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * add new scam account Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * Enable EOS.* assets on withdraw * Fixes renderCollateralBid() issue * Closes bitshares#2267 Closes bitshares#2265 Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * update bitsharesjs and other packages Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * update lock Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * refine asset_settle_instant Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * sync package lock Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * sync language files Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * add direct debit and timed transfer Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * add tooltip for borrow Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * undo changes, only formatting Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * add changes after reformatting Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * disable spotlights without account Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * Adding API server of ioBanker * update locales Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * add tooltips, closes bitshares#2270 * add snap release and token Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * switch to bitshares-ui-automation build Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * move snap token script Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * add execute permission Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * adjust snap token setting again Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * add pr template Signed-off-by: Stefan Schießl <stefan.schiessl@blockchainprojectsbv.com> * Disable Margin Trading Link on Dashboard for GS Asset Various code cleaning * Apply bit to bitAssets on Borrow Link * Fix Legacy WithdrawDeposit - BlockTrades input/output coin pair failure fixed - Disabled Winex, Citadel due to CORS issues crashing client * Fix EOS OL deposit gateway selection and address generation. * bitshares#2101 Update style-guide version to the latest * added new coins * bitshares#2207 Update style-guide version to the latest * bitshares#2254 Update style-guide version to the latest * Update locale-zh.json fix asset_create translate error * adjusted text Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * - remove node.btscharts.com (operator request) - refine min_deposit_warning_asset text Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * add voting shortcut * bitshares#2314 Remove ant inputs overrides on exchange * bitshares#1997 Update registration selector buttons regarding style-guide * bitshares#1997 Update Login selector regarding style-guide * bitshares#1997 Replace old components to style-guide. Remove unused code (password hide/show). Add Account Input for account name typing based on style-guide input * bitshares#1997 Replace old components to style-guide. Keep error reporting consistent (display error on input instead of notification) * bitshares#1997 Update registration cloud account to style-guide components * bitshares#1997 Update form type for cloud wallet form * bitshares#1997 Fix locale * bitshares#1997 Update wallet registration to style-guide components * bitshares#1997 Fix form html tag duplicate and add check for ref to exist * bitshares#1997 Fix padding for textarea * Catch empty Market history data * Fix paperwallet naming Adding private to private key wallet by default. * Add prop "ignorePriceFeed" to FormattedPrice * Settle Modal fixes - Use all funds by clicking on label - Disallow more than account holds - Tooltip on disable - Reset form on asset change * Adds the word TESTNET to footer when using a testnet node * Updating README and CONTRIBUTING files * Fixes currentAccount is in np not np.props * Disable margin update for GS assets on Margin Positions section * Enables the enter key for login and confirm modals * Return missing styles back * Catch invalid SettlePrice object * Update permission_utils.js when fullAccount is 'undefined',`new this.AccountPermission(fullAccount, null, type)` will throw an error and cause page broken. here add `if (!fullAccount) return` to fix this error. * Update+Add [Update]: "Silicone Valley" edited to be "Silicon Valley" [Add]: wss://singapore.bitshares.apasia.tech/ws * refine wording and componentWillReceiveProps for SettleModal Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * add new scam account Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * update PR template Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * Changes the testnet check * re-adding bitshares#2345, evaluating winex Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * - refactor footer a bit - only show accesssettings tooltip when accesssettingpopover not shown Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * sync language files Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * add remove-english-locale-duplicates Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * refine solution to a redirect Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * correct spelling of bridge * correct spelling of bridge * correct spelling of bridge * correct spelling of bridge * correct spelling of bridge * correct spelling of bridge * correct spelling of bridge * correct spelling of bridge * correct spelling of bridge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I find the color choices quite ugly, expecially the blue background of the markets / assets.
Thoughts?
The text was updated successfully, but these errors were encountered: