Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.5] Dashboard Portfolio columns #2311

Closed
TechsUsInc opened this issue Dec 11, 2018 · 6 comments · Fixed by #2644
Closed

[11.5] Dashboard Portfolio columns #2311

TechsUsInc opened this issue Dec 11, 2018 · 6 comments · Fixed by #2644
Assignees
@sschiessl-bcp
Labels
[1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [2] Good First Issue Issue is a good issue to start with [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [5d] Large Indicates size of task. Est. between four and ten hours [7] Estimated Administration flag, notifies hours are estimated and requires revisiting
Projects
190618 Release
Milestone
190510

Comments

@TechsUsInc
Copy link
Contributor

TechsUsInc commented Dec 11, 2018 •
edited

Describe the bug
The column value (BTS) is the only column underlined.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Dashboard Portfolio
  2. Note value (BTS) is the only column underlined
    181212-rc1_dashboard_portfolio_2capture

Expected behavior
Consistent with or without underlined columns

Desktop (please complete the following information):

  • OS: Windows 8.1
  • Browser Opera
  • Version 56.0.3051.116
  • Release 181212-rc1

Additional context
Consider replacing the column percent of Total Supply to % Total Supply
In the burn column, consider adding a "-" (to be consistent with the rest of the page), or "N/A", or "X" for bitassets
@TechsUsInc TechsUsInc mentioned this issue Dec 11, 2018
Closed
@startailcoon
Copy link
Contributor

Underlined header is the sorting column. This may not be obvious though.

Task

  • Add arrow up/down to sorted column, depending on order.
  • Underline all sortable columns
  • Rename percentage header
  • Fix non-burnable assets

@startailcoon startailcoon changed the title Dashboard Portfolio columns [0.5] Dashboard Portfolio columns Dec 15, 2018
@startailcoon startailcoon added [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [5a] Tiny Indicates size of task. Est. less than one hour [2] Good First Issue Issue is a good issue to start with [7] Estimated Administration flag, notifies hours are estimated and requires revisiting labels Dec 15, 2018
@startailcoon startailcoon added this to the 190103 milestone Dec 15, 2018
@sschiessl-bcp
Copy link
Contributor

Using style-guide table should resolve all that easily, right?

@sschiessl-bcp sschiessl-bcp self-assigned this Jan 9, 2019
This was referenced Jan 9, 2019
Closed
Closed
@sschiessl-bcp
Copy link
Contributor

Estimate for replacing with style guide is 6

@startailcoon startailcoon changed the title [0.5] Dashboard Portfolio columns [6] Dashboard Portfolio columns Feb 14, 2019
@startailcoon startailcoon modified the milestones: 190103, 190227 Feb 14, 2019
@clockworkgr clockworkgr modified the milestones: 190301, 190315 Mar 6, 2019
@clockworkgr clockworkgr modified the milestones: 190315, 190329 Mar 20, 2019
@clockworkgr clockworkgr modified the milestones: 190329, 190412 Apr 3, 2019
@startailcoon
Copy link
Contributor

@sschiessl-bcp do you have an update on the progress of this task?

@startailcoon startailcoon modified the milestones: 190412, 190426 Apr 14, 2019
@startailcoon startailcoon added [5d] Large Indicates size of task. Est. between four and ten hours and removed [5a] Tiny Indicates size of task. Est. less than one hour labels Apr 14, 2019
@sschiessl-bcp
Copy link
Contributor

Yes, PR soon

@sschiessl-bcp sschiessl-bcp mentioned this issue Apr 29, 2019
Merged
12 tasks
@clockworkgr clockworkgr modified the milestones: 190426, 190510 May 4, 2019
@sschiessl-bcp
Copy link
Contributor

Hours needed was 11.5 due to increased complexity. Many components have been streamlined and refactored, see visual overview here #2644 (comment)

Refactoring went also in the PaginatedList and Table component.

@sschiessl-bcp sschiessl-bcp added this to To do in 190618 Release via automation May 9, 2019
190618 Release automation moved this from To do to Done May 9, 2019
sschiessl-bcp pushed a commit that referenced this issue May 9, 2019
Merge pull request #2644 from blockchainprojects/2311_Dashboard_Portf…
e3dcb3c 
…olio_columns

#2311 dashboard portfolio columns
@startailcoon startailcoon changed the title [6] Dashboard Portfolio columns [11.5] Dashboard Portfolio columns May 10, 2019
@TBAPI-0KA TBAPI-0KA mentioned this issue May 13, 2019
Closed
@sschiessl-bcp sschiessl-bcp mentioned this issue Jun 9, 2019
Closed
@sschiessl-bcp sschiessl-bcp moved this from Done to Added to notes in 190618 Release Jun 11, 2019
190618 Release automation moved this from Added to notes to Done Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sschiessl-bcp sschiessl-bcp

Labels
[1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [2] Good First Issue Issue is a good issue to start with [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [5d] Large Indicates size of task. Est. between four and ten hours [7] Estimated Administration flag, notifies hours are estimated and requires revisiting
Projects
No open projects
190618 Release
  
In Release
Milestone
190510
Development

Successfully merging a pull request may close this issue.

#2311 dashboard portfolio columns blockchainprojects/bitshares-ui
4 participants
@clockworkgr @startailcoon @TechsUsInc @sschiessl-bcp