Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3] Vertical order book width is sometimes to small #2734

Closed
shulthz opened this issue May 30, 2019 · 6 comments · Fixed by #3089
Closed

[3] Vertical order book width is sometimes to small #2734

shulthz opened this issue May 30, 2019 · 6 comments · Fixed by #3089
Assignees
Labels
[1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive [7] Estimated Administration flag, notifies hours are estimated and requires revisiting
Milestone

Comments

@shulthz
Copy link
Contributor

shulthz commented May 30, 2019

图片
图片

I think need to low the NUMBER OF DECIMAL POINTS and asjust the font.

https://www.huobi.co/en-us/exchange/btc_usdt/
图片

图片

@shulthz shulthz changed the title Can'他 Can't show the price in the order book May 30, 2019
@abitmore
Copy link
Member

It's not due to number of decimals after the decimal point, but the numbers before the decimal point. HB's order book is not as thin as GDEX. For this kind of extreme case, I guess it's necessary to show the horizon scrollbar.

By the way, the 0.00001000 amount is clearly a bug, because GDEX.ETH's precision is 6, aka at most 6 decimals after the decimal point.

@startailcoon
Copy link
Contributor

startailcoon commented May 31, 2019

Indeed, when an orderbook is so narrow it displays all the obscure orders at the end of it we have a few markets with up to 10000x the market price, making the table unable to hold all the digits.

We need to look closer to the vertical order book view for this. The horizontal orderbook doesn't have this issue as it's limited to how many orders it displays initially.

@startailcoon startailcoon added [1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [3] Enhancement Classification indicating a change to the functionality of the existing imlementation labels May 31, 2019
@shulthz
Copy link
Contributor Author

shulthz commented Jun 4, 2019

Let‘s check:
https://olddex.cybex.io/market/JADE.BTC_JADE.USDT

@sschiessl-bcp
Copy link
Contributor

Would introduction of scientific notation help in that case? Is that feasible towards traders minds?

@startailcoon
Copy link
Contributor

I will take a closer look at this again. The panel has a fixed width, as it would grow when required, but never shrink, making the orderbooks with less space requirements be extremely stretched. The size only changed once reloaded.

@startailcoon startailcoon self-assigned this Jun 16, 2019
@startailcoon startailcoon added this to the 190621 milestone Jun 16, 2019
@startailcoon startailcoon changed the title Can't show the price in the order book [1] Vertical order book width is sometimes to small Jun 16, 2019
@clockworkgr clockworkgr modified the milestones: 190621, 190705 Jun 28, 2019
@startailcoon startailcoon modified the milestones: 190705, 190719 Jul 16, 2019
@clockworkgr clockworkgr modified the milestones: 190719, 190802 Jul 23, 2019
@startailcoon
Copy link
Contributor

I propose that when the price of a bid/ask goes away from the median to much, it's not going to be visible. This problem only persists mainly because the market has to few bids, and the edges are either 0.0000001 or 10000000.

We should only allow +1 digit from the median price. If the median is 1.0 we allow up to 99.9 to be visible. If the median is 10, we allow up to 999 etc.

Markets that has enough liquidity orders will not have this problem because the UI will never receive the edges of the order book.

However, there is also a requirement for a better handling of dynamic width, with is problematic with current structure and needs more time.

@startailcoon startailcoon added the [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive label Jul 24, 2019
@sschiessl-bcp sschiessl-bcp changed the title [1] Vertical order book width is sometimes to small [3] Vertical order book width is sometimes to small Oct 14, 2019
@sschiessl-bcp sschiessl-bcp added the [7] Estimated Administration flag, notifies hours are estimated and requires revisiting label Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive [7] Estimated Administration flag, notifies hours are estimated and requires revisiting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants