Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.25] [3.1.190618-rc1] Dashboard - margin position alignment #2790

Closed
froooze opened this issue Jun 17, 2019 · 2 comments · Fixed by #2822
Closed

[0.25] [3.1.190618-rc1] Dashboard - margin position alignment #2790

froooze opened this issue Jun 17, 2019 · 2 comments · Fixed by #2822
Assignees
@OpenLedgerApp
Labels
[1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [2] Good First Issue Issue is a good issue to start with [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [5a] Tiny Indicates size of task. Est. less than one hour [7] Finalized Administartion flag, notifies hours are finalized
Projects
190618 Release
Milestone
190621

Comments

@froooze
Copy link
Collaborator

froooze commented Jun 17, 2019

Describe the bug
When the margin position window is in wide position the column Total BTS until Feed Price is not aligned on the right side

To Reproduce
Steps to reproduce the behavior:

  1. Go to margin position
  2. Put Window in max wide
  3. See error

Expected behavior
Same alignment as other columns

Screenshots
margin-position-layout

Desktop (please complete the following information):

  • OS: MX-Linux, Light client
@froooze froooze changed the title [3.1.190618-rc1] - margin position layout [3.1.190618-rc1] - margin position alignment Jun 18, 2019
@froooze froooze changed the title [3.1.190618-rc1] - margin position alignment [3.1.190618-rc1] - Dashboard - margin position alignment Jun 18, 2019
@froooze froooze changed the title [3.1.190618-rc1] - Dashboard - margin position alignment [3.1.190618-rc1] Dashboard - margin position alignment Jun 18, 2019
@sschiessl-bcp
Copy link
Contributor

Looks like content is centered

@startailcoon startailcoon added [1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [2] Good First Issue Issue is a good issue to start with [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [5a] Tiny Indicates size of task. Est. less than one hour [7] Estimated Administration flag, notifies hours are estimated and requires revisiting labels Jun 18, 2019
@startailcoon startailcoon added this to the Active Development milestone Jun 18, 2019
@startailcoon startailcoon changed the title [3.1.190618-rc1] Dashboard - margin position alignment [0.25] [3.1.190618-rc1] Dashboard - margin position alignment Jun 18, 2019
@OpenLedgerApp
Copy link

@startailcoon I can take this one

OpenLedgerApp pushed a commit to OpenLedgerApp/bitshares-ui that referenced this issue Jun 24, 2019
bitshares#2790. change total balance column alignment
2386a0e
@OpenLedgerApp OpenLedgerApp mentioned this issue Jun 24, 2019
Merged
12 tasks
@sschiessl-bcp sschiessl-bcp added this to To do in 190618 Release via automation Jun 24, 2019
@sschiessl-bcp sschiessl-bcp modified the milestones: 190705, 190621 Jun 24, 2019
190618 Release automation moved this from To do to Done Jun 24, 2019
sschiessl-bcp pushed a commit that referenced this issue Jun 24, 2019
Merge pull request #2822 from OpenLedgerApp/#2790-margin-position-ali…
aacd858 
…gnment

#2790. margin position alignment
gades pushed a commit to piratecash/pirate-dex that referenced this issue Jun 24, 2019
@gades
bitshares#2790. change total balance column alignment
05f0976
@sschiessl-bcp sschiessl-bcp moved this from Done to Added to notes in 190618 Release Jun 25, 2019
@sschiessl-bcp sschiessl-bcp mentioned this issue Jun 25, 2019
Closed
@froooze froooze mentioned this issue Jun 27, 2019
Closed
12 tasks
190618 Release automation moved this from Added to notes to Done Jun 27, 2019
@clockworkgr clockworkgr added [7] Finalized Administartion flag, notifies hours are finalized and removed [7] Estimated Administration flag, notifies hours are estimated and requires revisiting labels Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OpenLedgerApp OpenLedgerApp

Labels
[1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [2] Good First Issue Issue is a good issue to start with [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [5a] Tiny Indicates size of task. Est. less than one hour [7] Finalized Administartion flag, notifies hours are finalized
Projects
No open projects
190618 Release
  
In Release
Milestone
190621
Development

Successfully merging a pull request may close this issue.

#2790. margin position alignment OpenLedgerApp/bitshares-ui
5 participants
@clockworkgr @startailcoon @sschiessl-bcp @froooze @OpenLedgerApp