Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2] Allow "single" change of Fee asset on TX #2969

Open
startailcoon opened this issue Jul 21, 2019 · 5 comments
Open

[2] Allow "single" change of Fee asset on TX #2969

startailcoon opened this issue Jul 21, 2019 · 5 comments
Labels
[1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [5c] Medium Indicates size of task. Est. between two and four hours

Comments

@startailcoon
Copy link
Contributor

startailcoon commented Jul 21, 2019

My own opinion is that it would be nice to have a "change fee asset directly" when yo do a transaction, that doesn't stick to be the default, but just for that one op. But that's for a followup issue I think.

Originally posted by @startailcoon in #1117 (comment)

With the new Fee selection component we can now let the user select the default fee asset in a nice view. At the moment we have not enabled this feature directly on the Transaction confirmation itself, which would be a nice addition.

Related are #1498

@startailcoon startailcoon added [1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [5c] Medium Indicates size of task. Est. between two and four hours labels Jul 21, 2019
@startailcoon startailcoon added this to the Active Development milestone Jul 21, 2019
@startailcoon startailcoon changed the title Allow "single" change of Fee asset on TX [2] Allow "single" change of Fee asset on TX Jul 21, 2019
@OpenLedgerApp
Copy link

@startailcoon I can take this one.

@startailcoon
Copy link
Contributor Author

Assigned you @OpenLedgerApp

@sschiessl-bcp
Copy link
Contributor

The task at hand is to allow that the user to change the fee at hand directly in the TransactionConfirm modal. It should be minimal inversive. Currently there is only a "?" icon with a tooltip. We want a new icon (or replacement) next to it (e.g. the change icon) that will on-click make the fee asset selectable. This does not require any fee calculation overhead since the BTS fee is fixed and merely has to be converted using the CER, and it should not persist the fee asset selection to settings.

@startailcoon
Copy link
Contributor Author

[...] would be nice to have a "change fee asset directly" when yo do a transaction, that doesn't stick to be the default [...] let the user select the default fee asset in a nice view. At the moment we have not enabled this feature directly [...]

I thought I was clear in my comment on the original post. The linked issue would have given more details on the subject as well.

@sschiessl-bcp sschiessl-bcp modified the milestones: 190802, 190816 Aug 11, 2019
@startailcoon
Copy link
Contributor Author

@OpenLedgerApp what is your status on this issue, where you clear on what the end result was supposed to be with the latest comments? Otherwise, please post any required clarifications here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [5c] Medium Indicates size of task. Est. between two and four hours
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants