Adding support for *default fee paying asset* in ApplicationApi

[ioBanker]

User had reported that feeAsset is turning into liquidity pool asset while attempting to perform withdraw from a liquidity pool, seems bug is effecting objects.feeAsset.get("id") default object at liquidity pools withdraw modal which should show feeAsset as core asset.

Before fixing the bug:

After fixing the bug:

[abitmore]

This is actually an old issue. I don't think the fix is appropriate though. See #2969

[ioBanker]

This is actually an old issue. I don't think the fix is appropriate though. See #2969

I know what you mean hence for now mostly people are paying liquidity pools transaction fees in BTS.

I am considering this: #3001 (comment) I believe its ready but will need to check the bug @sschiessl-bcp is referring to.

[ioBanker]

@sschiessl-bcp please pass this for now as some users are not able to pay fees with BTS.

Note: this change is effecting only liquidity removal operation of liquidity pool transaction fees.

[abitmore]

Actually I think we should extend the fix in #3492 to all operations: call accountUtils.getFinalFeeAsset() to get an available asset (maybe globally in some way).

[ioBanker]

Seems already implemented at loan modal; will check the code there if it can be easily implemented here for all

[sschiessl-bcp]

Seems already implemented at loan modal; will check the code there if it can be easily implemented here for all

Had time to check?

[ioBanker]

Seems already implemented at loan modal; will check the code there if it can be easily implemented here for all

Had time to check?

will be checking this weekend and then update here.

[ioBanker]

Hello @sschiessl-bcp; I'd just checked and such a change would require complex work, for now please merge this fix as it's preventing some liquidity pool users to pay with BTS.

Perhaps another feature implementation like this open case be created later #3088

[abitmore]

@ioBanker see my comment #3540 (comment)

Actually I think we should extend the fix in #3492 to all operations: call accountUtils.getFinalFeeAsset() to get an available asset (maybe globally in some way).

Don't merge this. Please fix it.

[ioBanker]

@ioBanker see my comment #3540 (comment)

Actually I think we should extend the fix in #3492 to all operations: call accountUtils.getFinalFeeAsset() to get an available asset (maybe globally in some way).

Don't merge this. Please fix it.

Fixed and was tested.

Credits to @thontron for tests

[ioBanker]

accountUtils.getFinalFeeAsset(account,"liquidity_pool_withdraw") is successfully working

It can be merged now.

[sschiessl-bcp]

Looking at the actual code change, I see the following:

In ApplicationAPI you define

bitshares-ui/app/api/ApplicationApi.js

Lines 989 to 996 in 9e4d1d8

	async liquidityPoolWithdraw(
	account,
	liquidityPoolId,
	shareAsset,
	shareAmount,
	feeAsset = "1.3.0",
	broadcast = true
	) {

but when calling it you are using

bitshares-ui/app/components/Modal/PoolStakeModal.jsx

Lines 110 to 120 in 9e4d1d8

	ApplicationApi.liquidityPoolWithdraw(
	account,
	pool.get("id"),
	pool.getIn(['share_asset', "symbol"]),
	Math.floor(Number(shareAssetAmount) * Number(sharedAssetPrecision)),
	pool.getIn(['asset_a', "symbol"]),
	pool.getIn(['asset_b', "symbol"]),
	Math.floor(Number(assetAAmount) * Number(assetAPrecision)),
	Math.floor(Number(assetBAmount) * Number(assetBPrecision))
	)

Please fix the function arguments and implement the fix according to

bitshares-ui/app/actions/AccountActions.js

Line 73 in 9e4d1d8

fee_asset_id = accountUtils.getFinalFeeAsset(

, which has the proper fallback options. Is this maybe the same for deposit?

[ioBanker]

Looking at the actual code change, I see the following:

In ApplicationAPI you define

bitshares-ui/app/api/ApplicationApi.js

Lines 989 to 996 in 9e4d1d8

	async liquidityPoolWithdraw(
	account,
	liquidityPoolId,
	shareAsset,
	shareAmount,
	feeAsset = "1.3.0",
	broadcast = true
	) {

but when calling it you are using

bitshares-ui/app/components/Modal/PoolStakeModal.jsx

Lines 110 to 120 in 9e4d1d8

	ApplicationApi.liquidityPoolWithdraw(
	account,
	pool.get("id"),
	pool.getIn(['share_asset', "symbol"]),
	Math.floor(Number(shareAssetAmount) * Number(sharedAssetPrecision)),
	pool.getIn(['asset_a', "symbol"]),
	pool.getIn(['asset_b', "symbol"]),
	Math.floor(Number(assetAAmount) * Number(assetAPrecision)),
	Math.floor(Number(assetBAmount) * Number(assetBPrecision))
	)

Please fix the function arguments and implement the fix according to

bitshares-ui/app/actions/AccountActions.js

Line 73 in 9e4d1d8

fee_asset_id = accountUtils.getFinalFeeAsset(

, which has the proper fallback options. Is this maybe the same for deposit?

Good catch; liquidityPoolWithdraw arguments are wrong as assetA and assetB shouldn't be mentioned for this operation unlike deposit, will fix this soon later.

[ioBanker]

Below operations execution should be tested while setting a different asset "that has BTS in fee pool" prior merging this:

account_create
transfer
proposal_create
asset_issue
worker_create
withdraw_permission_create
withdraw_permission_update
withdraw_permission_claim
withdraw_permission_delete
vesting_balance_create
ticket_create
liquidity_pool_create
liquidity_pool_delete
liquidity_pool_deposit
liquidity_pool_withdraw
liquidity_pool_exchange

[ioBanker]

transfer - Tested
asset_issue - Tested
worker_create - Tested
ticket_create - Tested
liquidity_pool_create - Tested
liquidity_pool_delete - Tested
liquidity_pool_deposit - Tested
liquidity_pool_withdraw - Tested
liquidity_pool_exchange - Tested

I'd merged this change into dex.iobanker.com , please help with testing the other operations.

[abitmore]

Thanks.

[sschiessl-bcp]

I've changed the behavior to "if fee asset given, then use this, if not, use getFinalFeeAsset"

[abitmore]

This should be to.