Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credit offer repayment period "No limit" #3490

Closed
abitmore opened this issue Apr 10, 2022 · 3 comments · Fixed by #3493 or #3496
Closed

Credit offer repayment period "No limit" #3490

abitmore opened this issue Apr 10, 2022 · 3 comments · Fixed by #3493 or #3496
Projects
5.0.220701 Release

Comments

@abitmore
Copy link
Member

abitmore commented Apr 10, 2022 •
edited
Loading

Describe the bug

When the repayment period of an offer is not within the predefined set of UI, it shows as "No limit".

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://develop.bitshares.org/#/lending/p2p
  2. Scroll down to '1.21.67'
  3. See error

Expected behavior
Correct values on the page.

Screenshots
image

Desktop (please complete the following information):
/

Additional context
Add any other context about the problem here.
xiangxn added a commit to xiangxn/bitshares-ui that referenced this issue Apr 15, 2022
@xiangxn
fix bitshares#3490, Credit offer repayment period 'No limit'
88e9d3b
@xiangxn xiangxn mentioned this issue Apr 15, 2022
Merged
@xiangxn
Copy link
Contributor

xiangxn commented Apr 15, 2022 •
edited
Loading

I have dealt with this issue, if you have time you can review and merge.
image

@sschiessl-bcp @abitmore

@sschiessl-bcp sschiessl-bcp added this to To do in 5.0.220701 Release via automation Apr 16, 2022
5.0.220701 Release automation moved this from To do to Done Apr 16, 2022
sschiessl-bcp added a commit that referenced this issue Apr 16, 2022
@sschiessl-bcp
Merge pull request #3493 from xiangxn/fix-3490
4ee0de3 
fix #3490, Credit offer repayment period 'No limit'
@abitmore
Copy link
Member Author

Better add some white spaces. BTW "1Hours" and "1Days" look strange, they should be "1 hour" or "1 day". Actually, do we have some standard i18n library to use?

image

@abitmore abitmore reopened this Apr 16, 2022
5.0.220701 Release automation moved this from Done to In progress Apr 16, 2022
@xiangxn xiangxn mentioned this issue Apr 17, 2022
Merged
@xiangxn
Copy link
Contributor

xiangxn commented Apr 17, 2022

I have reformatted it.

@abitmore

5.0.220701 Release automation moved this from In progress to Done Apr 18, 2022
sschiessl-bcp added a commit that referenced this issue Apr 18, 2022
@sschiessl-bcp
Merge pull request #3496 from xiangxn/fix-3490
46524ec 
Fix credit offer repayment period "No limit" #3490
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
5.0.220701 Release
Done
Milestone
No milestone
2 participants
@xiangxn @abitmore