[.5][happyconcepts] Display account name in lower case letters

[btswolf]

To avoid confusion with the account names I suggest to display the account name with lower case letters consistently in the whole GUI.

[ghost]

The standard reference throughout the GUI:

all "ASSETS" should be "UPPER CASE"
all "user names" should be "lower case"

CAPITALISATION of Tabs/titles should also be removed for visual consistency.

[btsfav]

merge with #187 please @wmbutler

[happyconcepts]

@wmbutler @btsfav I can fix the account names for the current sprint if you like; however the relation to #187 eludes me.

EDIT: Confirmed: the recipient's Bitshares address (user input) is already lower-cased in the form field on the SEND page.

[wmbutler]

I like the consistency of all assets UC and all uernames LC. Does commit 6b65bb1 cover thi throughout the entire wallet?

[happyconcepts]

More testing is always welcomed as I don't have much experience writing unit tests. I'm learning Travis but not at production level yet.

[happyconcepts]

FWIW the uppercase transform was being applied to everything in the header; I don't see a use case for capitalizing the account names in any other place in the current GUI.

[wmbutler]

It's not a matter of user case really, it's just a consistency thing.

[happyconcepts]

Well in the meantime, if we are sure that React's use of the variable declaration
account_display_name is enforced throughout all the jsx files ... then I can search the codebase:

https://github.com/bitshares/bitshares-ui/search?utf8=%E2%9C%93&q=account_display_name&type=

Is there a 2.0 or 2.x style/implementation guide I can refer to?

[wmbutler]

@svk31 may have an answer for you. Should I add a bit more time to accommodate this?

[happyconcepts]

Sure, very happy to help with these smaller issues for 0914.

[landry314]

If you click on the username tab on the upper right while multiple accounts are starred then a menu pulls down with the usernames still in ALL CAPS. If we are trying to be consistent throughout the GUI then should we change it here too.

[landry314]

Is commenting in a closed issue thread a bad idea? It seems to get lost more often. I commented here because it is directly related to this issue. There are still account names in uppercase letters...

@happyconcepts, do you want to handle this?

[happyconcepts]

I was going to make that change before I was fuzzed, sidelined and forgotten. You fuzzed me here from my very first post @landry314 @landryracoon @whatevernewnameyoumaketoday so this is great for you to come stalk all my PRs too.

…

On Mon, Oct 16, 2017 at 6:56 AM, Landry Racoon ***@***.***> wrote: Is commenting in a closed issue thread a bad idea? It seems to get lost more often. I commented here because it is directly related to this issue. There are still account names in uppercase letters... @happyconcepts <https://github.com/happyconcepts>, do you want to handle this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#358 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANfZLE8CZmUWMhKnGgdAawZugk0k1lhSks5ss2CKgaJpZM4PLJje> .

[landry314]

I am just trying to help the program, not insulting or stalking you. I noticed there is another place where this comes up so I posted it but it seemed to go unnoticed. I think posting in closed issues doesn't work very well so I tagged you because you were assigned this before.

[happyconcepts]

PR is submitted.