Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credit_offer_accept_operation doesn't show in proposals #3661

Open
abitmore opened this issue Sep 3, 2023 · 1 comment
Open

Credit_offer_accept_operation doesn't show in proposals #3661

abitmore opened this issue Sep 3, 2023 · 1 comment
Labels
[4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive

Comments

@abitmore
Copy link
Member

abitmore commented Sep 3, 2023 •
edited
Loading

Describe the bug

See https://develop.bitshares.org/#/account/blockchain-prize and screenshots below.

This leads to potential on-chain phishing activities.

Victims may think the proposals are free offers and accept them, and end up losing more.

Additional Context

There was PR #2704 to render all operations inside proposals, but the related code hasn't been updated for a long time. When new operations got added to the blockchain, they show as a simple "#" in proposals.
I think the idea behind #2704 was to eventually stop using /app/components/Blockchain/OperationAnt.js to render operations, but unfortunately we're still not there yet.

Screenshots
image

image
@abitmore abitmore added the [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive label Sep 3, 2023
@abitmore
Copy link
Member Author

abitmore commented Sep 3, 2023

Additional Context

There was PR #2704 to render all operations inside proposals, but the related code hasn't been updated for a long time. When new operations got added to the blockchain, they show as a simple "#" in proposals.
I think the idea behind #2704 was to eventually stop using /app/components/Blockchain/OperationAnt.js to render operations, but unfortunately we're still not there yet.

@abitmore abitmore mentioned this issue Sep 3, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abitmore