Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearly render proposal contents #2704

Conversation

sschiessl-bcp
Copy link
Contributor

@sschiessl-bcp sschiessl-bcp commented May 21, 2019

General

Closes #2499

Component rendering received a complete overhaul and streamlined in terms of what gets displayed where. On top of that, account update now displayes the exact changes.

Every operation (54) now has it's own component with clear separation what is being displayed instead of one massive if else clause. Furthermore, rebasing was necessary to accomodate the changes for new HTLC that were done in old format.

With all that in mind, I request a bounty increase to 15. Total hours spent were 42.

General

Please make sure the following is done:

Code Preparation

Please review all your changes one last time before committing

  • Check for unused code
  • No unrelated changes are included
  • None of the changed files are reformatting only
  • Code is self explanatory or documented
  • All written text is properly translated (english language)

Testing

The branch has been tested on the following browsers (desktop and mobile view)

  • Chrome
  • Opera
  • Firefox
  • Safari

User interface changes

Delete this section if there weren't any UI changes. Please make sure you tested your changes in all themes

  • Dark
  • Light
  • Midnight

Please provide screenshots/licecap of your changes below

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[4] Clearly render proposal contents
2 participants