Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.5][dot5enko][0.25][startailcoon] News does not load in light client #887

Closed
btsfav opened this issue Dec 20, 2017 · 12 comments
Closed

[1.5][dot5enko][0.25][startailcoon] News does not load in light client #887

btsfav opened this issue Dec 20, 2017 · 12 comments
Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design
Milestone
180215

Comments

@btsfav
Copy link

btsfav commented Dec 20, 2017

app.js:53 Unhandled rejection TypeError: g is not a constructor
@wmbutler
Copy link
Contributor

Might be nice to run this as a hotfix

@wmbutler wmbutler changed the title News do not load in light client [.25] News do not load in light client Dec 21, 2017
@wmbutler wmbutler added the [3] Bug Classification indicating the existing implementation does not match the intention of the design label Dec 21, 2017
@wmbutler wmbutler added this to the 180105 milestone Dec 21, 2017
@wmbutler wmbutler changed the title [.25] News do not load in light client [.5] News do not load in light client Dec 24, 2017
@wmbutler wmbutler changed the title [.5] News do not load in light client [1] News do not load in light client Dec 25, 2017
@wmbutler
Copy link
Contributor

  • News does not load in light client
  • Date appears to be incorrect in some cases. This article shows a date of 21 Dec in the BTS wallet, but in STEEM, it says it was published 10 days ago (the current date as of this writing was Dec 25, implying an original publication date of 15 Dec.)

screen shot 2017-12-25 at 12 27 10 am
screen shot 2017-12-25 at 12 27 05 am
screen shot 2017-12-25 at 12 26 49 am

@wmbutler
Copy link
Contributor

+.5 for date bug fix as well.

@wmbutler wmbutler changed the title [1] News do not load in light client [1.5] News do not load in light client Dec 25, 2017
HarukaMa added a commit to HarukaMa/bitshares-ui that referenced this issue Dec 26, 2017
@HarukaMa
Fix incorrect news publish date, part of bitshares#887
3c707f8
HarukaMa added a commit to HarukaMa/bitshares-ui that referenced this issue Dec 26, 2017
@HarukaMa
Fix incorrect news publish date, part of bitshares#887
b16d45c
@HarukaMa
Copy link
Contributor

TypeError: WebSocket is not a constructor
from steem package in api/transports/ws.js, seems it can't get package ws in electron.

Date bug fix is in #913.

@wmbutler
Copy link
Contributor

@HarukaMa are you planning to claim the Light Client fix as well or do I need to break this into 2 issues?

@dot5enko
Copy link
Contributor

i can take over light client bug if @HarukaMa would not claim it

@wmbutler wmbutler changed the title [1.5] News do not load in light client [1.5][dot5enko] News do not load in light client Dec 27, 2017
@wmbutler
Copy link
Contributor

@dot5enko it's yours.

@wmbutler wmbutler changed the title [1.5][dot5enko] News do not load in light client [1.5][dot5enko] News does not load in light client Dec 27, 2017
HarukaMa added a commit to HarukaMa/bitshares-ui that referenced this issue Dec 27, 2017
@HarukaMa
Fix incorrect news publish date, part of bitshares#887
56d6399
@dot5enko
Copy link
Contributor

@svk31, the problem is in steem library, after webpack it turns to be empty object which cause an error.
I came up to stackoverflow with similar problem but it changed nothing, so i need a help of someone experienced with webpack.

svk31 pushed a commit that referenced this issue Dec 31, 2017
@HarukaMa @svk31
Fix incorrect news publish date, part of #887 (#913)
0fe1c8d
@dot5enko
Copy link
Contributor

dot5enko commented Jan 3, 2018

@svk31 can you help me with this ?

@wmbutler
Copy link
Contributor

wmbutler commented Jan 6, 2018

@svk31 did this make it into the current release? If not, please push, otherwise close.

@wmbutler wmbutler modified the milestones: 180108, 180115 Jan 10, 2018
@svk31 svk31 modified the milestones: 180115, 180201 Jan 15, 2018
@wmbutler
Copy link
Contributor

wmbutler commented Feb 2, 2018

  • News isn't loading in the web wallet now.

@wmbutler wmbutler modified the milestones: 180201, 180215 Feb 2, 2018
@startailcoon startailcoon mentioned this issue Feb 11, 2018
Closed
@startailcoon
Copy link
Contributor

News is now loading again, as the issue was the API URL the client was trying to load from wasn't correct.
This section still needs some love though.

@startailcoon startailcoon changed the title [1.5][dot5enko] News does not load in light client [1.5][dot5enko][0.25][startailcoon] News does not load in light client Feb 11, 2018
@svk31 svk31 closed this as completed in c15336e Feb 12, 2018
Cryptolero pushed a commit to CryptoBridge/cryptobridge-ui that referenced this issue Nov 2, 2018
@HarukaMa @svk31
Fix incorrect news publish date, part of bitshares#887 (bitshares#913)
4679488
Cryptolero pushed a commit to CryptoBridge/cryptobridge-ui that referenced this issue Nov 2, 2018
@svk31
Update steem package, fix bitshares#887
74a7a71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design
Projects
None yet
Milestone
180215
Development

No branches or pull requests
6 participants
@HarukaMa @wmbutler @dot5enko @svk31 @startailcoon @btsfav