Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

128 charting library removal #2845

Conversation

sschiessl-bcp
Copy link
Contributor

General

Closes #2826
  1. Created script (npm run package-charting-library) that archives the source code content of the charting_library folder into one file (content as it is right now, .zip or .tar or whatever is easiest, I don't want many additional dependencies, and all dependencies should be devDependencies) and writes the .md5 file for the archive
  2. Create script (npm run install-charting-library) that
    downloads the previously packaged file from an external URLhttps://bitshares.org/assets/charting_library.zip
    verifies the downloaded file against the .md5 file checksum
    unpacks it such that the charting_library folder is fully restored locally
  3. Deleted source code within the charting_library folder
  4. Added postinstall script to npm to set up charting library from remote assets

General

Please make sure the following is done:

Code Preparation

Please review all your changes one last time before committing

  • Check for unused code
  • No unrelated changes are included
  • None of the changed files are reformatting only
  • Code is self explanatory or documented
  • All written text is properly translated (english language)

Testing

The branch has been tested on the following browsers (desktop and mobile view)

  • Chrome
  • Opera
  • Firefox
  • Safari

User interface changes

Delete this section if there weren't any UI changes. Please make sure you tested your changes in all themes

  • Dark
  • Light
  • Midnight

Please provide screenshots/licecap of your changes below

@sschiessl-bcp sschiessl-bcp added this to In progress in 191120 Release via automation Jun 28, 2019
@sschiessl-bcp sschiessl-bcp added [3] Refactoring Classification indicating a change to code refactoring. [7] Estimated Administration flag, notifies hours are estimated and requires revisiting labels Jun 28, 2019
@sschiessl-bcp sschiessl-bcp merged commit 1b5fbc8 into bitshares:develop Jun 28, 2019
191120 Release automation moved this from In progress to Done Jun 28, 2019
@sschiessl-bcp sschiessl-bcp moved this from Done to In Notes in 191120 Release Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[3] Refactoring Classification indicating a change to code refactoring. [7] Estimated Administration flag, notifies hours are estimated and requires revisiting
Projects
No open projects
191120 Release
  
In Notes
Development

Successfully merging this pull request may close these issues.

[3] Remove charting library from github
2 participants