Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create disclaimer.md #3543

Merged
merged 3 commits into from
Sep 18, 2022
Merged

Create disclaimer.md #3543

merged 3 commits into from
Sep 18, 2022

Conversation

ioBanker
Copy link
Member

No description provided.

@ioBanker
Copy link
Member Author

ioBanker commented Sep 9, 2022

It will look like this:

image

image

@sschiessl-bcp
Copy link
Contributor

We discussed this in TG a bit, and the latest changes come inspired by https://bitcoin.org/en/legal#information

@sschiessl-bcp
Copy link
Contributor

sschiessl-bcp commented Sep 14, 2022

@abitmore any thoughts?

Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sschiessl-bcp
remove overhead that belongs in readme

Do we have a link in the wallet to show the contents? If not, I think we need one. Contents in readme does not show in the wallet though.

@sschiessl-bcp
Copy link
Contributor

@ioBanker can you please add the disclaimer as first item in the left menu when help is open?

@ioBanker
Copy link
Member Author

It's there already in footer; check the print screens, it will stay in footer all the time, I doubt it's needed in help menu.

@ioBanker
Copy link
Member Author

The pull request of the link: #3543

@ioBanker
Copy link
Member Author

#3557 #3556

Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ioBanker please close the new pull requests and make the changes in this PR. Thanks.

I'm fine if @sschiessl-bcp accepts multiple pull requests though.

@sschiessl-bcp sschiessl-bcp merged commit 24d4e63 into bitshares:develop Sep 18, 2022
@sschiessl-bcp sschiessl-bcp added this to In progress in 5.0.230113 Release via automation Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants