Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Float-to-Integer producing too many digits #3547

Merged
merged 1 commit into from
Sep 18, 2022
Merged

Fixing Float-to-Integer producing too many digits #3547

merged 1 commit into from
Sep 18, 2022

Conversation

ioBanker
Copy link
Member

Closes #3545

@sschiessl-bcp
Copy link
Contributor

Does this sove the issue shown in the screen? You are calculating a value in satoshis, and 0.00013 is misrepresented by 129999999998. Rounding the latter should still give you 129999999998?

@ioBanker
Copy link
Member Author

Yeah; it solved the issue:

Before:
photo_2022-09-03_20-28-42

After:
photo_2022-09-03_21-15-13

Credits belongs to @christophersanborn

@sschiessl-bcp
Copy link
Contributor

You are right, I misjudged

@sschiessl-bcp sschiessl-bcp merged commit ad8cc7d into bitshares:develop Sep 18, 2022
@sschiessl-bcp sschiessl-bcp added this to In progress in 5.0.230113 Release via automation Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
5.0.230113 Release
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Float-to-Integer conversion producing too many digits in Liquidity Pool exchange
2 participants
@ioBanker @sschiessl-bcp