Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LP staking (A determine B and B determine A) #3548

Merged
merged 4 commits into from
Oct 3, 2022

Conversation

ioBanker
Copy link
Member

Closes #3546

Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terrible code formatting :P

@ioBanker
Copy link
Member Author

I know I am a horrible street coder; perhaps you and @sschiessl-bcp can forgive me 🙈 please help with formatting

@sschiessl-bcp
Copy link
Contributor

You really need to setup a proper IDE or environment locally that includes the formatting configured (e.g. WebStorm). Editing this via browser is really not recommended.

Short learning curve, I promise you you will gain a lot!

@ioBanker
Copy link
Member Author

Thanks for the formatting; I believe the change is working fine as we'd tested it for the past 3 days massively.

@sschiessl-bcp
Copy link
Contributor

Tested another edge case, seems fine

@sschiessl-bcp sschiessl-bcp merged commit 0f81953 into bitshares:develop Oct 3, 2022
@sschiessl-bcp sschiessl-bcp added this to In progress in 5.0.230113 Release via automation Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Adding liquidity pool feature request
3 participants