Iss 351 - Failed to Sync with API Server UI #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svk31
suggested changes
Sep 12, 2017
app/components/SyncError.jsx
Outdated
| } | ||
|
|
||
| render() { | ||
| const { props } = this; | ||
| let options = this.props.apis.map(entry => { |
There was a problem hiding this comment.
You can remove this since it's not used anymore
app/components/SyncError.jsx
Outdated
| @@ -48,55 +52,20 @@ class SyncError extends React.Component { | |||
| return ( | |||
|
|
|||
| <div className="grid-frame vertical"> | |||
|
|
|||
| <div className="grid-container text-center" style={{paddingTop: "5rem", maxWidth: "40rem"}}> | |||
| <div className="grid-container text-center" style={{paddingTop: "5rem", maxWidth: "90%", overflowY: "auto"}}> | |||
There was a problem hiding this comment.
It looks weird on a wide screen, with the scrollbar indented from the right:
|
Made so scrollbar appears in extreme right hand side |
svk31
approved these changes
Sep 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #351