Feature: Message signing and verifying #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 8, 2017 17:40
Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>
Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>
Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>
|
This looks awesome, nice work! @wmbutler I suppose you'd like to offer some input on the UX? |
|
This feature offer some very nice possivilities ... No people can proof ownership of an account to anyone without sending transactions around .. |
|
I'm merging this as is and we can work on the styling etc later, thanks for the PR! |
|
Thank you @svk31 . I'm happy that it got accepted. I'll be happy for styling suggestions! One thing that is currently missing as functionality: The setting of the "Verify while typing" slider is not stored on an per-user basis, it is simply off everytime the user restarts the app. |
CryptoBridge
pushed a commit
to CryptoBridge/cryptobridge-ui
that referenced
this pull request
Nov 23, 2017
* first version for message signing Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * added proper message format with head/meta/signature/foot Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com> * code cleanup, refactor and documentation Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear BitShares community,
this feature pull request adds message signing and verifying into the advanced features section in the account overview. The user can write and sign messages and verify ones from other accounts, see attached screenshots.
The format of a message follows common styleguides for signed messages. It contains a header / meta / signature / footer tag (this format is of course up to discussion):
-----BEGIN BITSHARES SIGNED MESSAGE-----
[message from the account]
-----BEGIN META-----
account=[account name]
memokey=[account memo public key]
block=[last irreversible block]
timestamp=[current time]
-----BEGIN SIGNATURE-----
[signature]
-----END BITSHARES SIGNED MESSAGE-----
I simply created the functionality without concerning myself too much with the visualization, I would like to ask you for interface design suggestions here as well. Also, please do not hesitate to give any feedback, comments or improvement suggestions. Furthermore, if I may ask for that, I would like feedback on my code style (potential no-gos), and maybe if there are standards that I overlooked to use that the BitShares platform is using.
Best regards,
Stefan Schießl
Blockchain Projects BV