Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSIP 57: Managed Vesting Policy, plus Savings Account #119

Merged

Conversation

sschiessl-bcp
Copy link
Collaborator

@sschiessl-bcp sschiessl-bcp commented Nov 5, 2018

Dear BitShares Community,

allow us to introduce a new BSIP that will enable off-chain activities that can be settled transparently on the blockchain, and implicitly enables the creation of savings accounts for the users that are locked a certain time period to enhance fund security.

For an easy read, please find the file here:
https://github.com/blockchainprojects/bsips/blob/56_Managed_Vesting_Policies/bsip-0056.md

Best regards,
Stefan
Blockchain Projects BV

Signed-off-by: Stefan Schiessl stefan.schiessl@blockchainprojectsbv.com

Stefan Schiessl added 2 commits November 5, 2018 16:18
Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>
bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
@sschiessl-bcp
Copy link
Collaborator Author

sschiessl-bcp commented Nov 7, 2018

All reviews implemented up until now, except the question when a user is allowed to initiate the withdrawal.

@sschiessl-bcp
Copy link
Collaborator Author

sschiessl-bcp commented Nov 7, 2018

In the discussion in telegram yesterday I also got another idea here.

The manager could be allowed to also put limit_orders on market A/B if he is managing a vesting balance for both assets for the same owner.

Does that take it too far?

@pmconrad
Copy link
Contributor

pmconrad commented Nov 7, 2018

Does that take it too far?

Yes. It would be a nightmare to keep track of which orders were created by whom from what balance. Note that manager is still able to trade on his own CEX using vesting balances from different users, then settle as usual.

bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
@sschiessl-bcp
Copy link
Collaborator Author

sschiessl-bcp commented Nov 12, 2018

@abitmore @oxarbitrage @ryanRfox

I would be very interested if you have any remarks on this?

@sschiessl-bcp
Copy link
Collaborator Author

How to decide that this is ready to be merged @ryanRfox ?

Can I request another review from any of the core team members?

@ryanRfox
Copy link
Contributor

ryanRfox commented Dec 3, 2018

I feel this draft is complete and can be merged. I will ask the Core Team for final remarks.

bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
@sschiessl-bcp
Copy link
Collaborator Author

All comments from Michal's review worked in.

@sschiessl-bcp
Copy link
Collaborator Author

Thanks a lot for the review @pmconrad and @MichelSantos

@xeroc
Copy link
Member

xeroc commented Dec 18, 2018

@pmconrad, @MichelSantos can I please request a final review and approval of this PR?

bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
bsip-0056.md Outdated Show resolved Hide resolved
@sschiessl-bcp
Copy link
Collaborator Author

all done, please merge

@xeroc xeroc merged commit 04a80cc into bitshares:master Jan 7, 2019
@sschiessl-bcp
Copy link
Collaborator Author

Pull request has been merged due to approval of Ryan, thanks all for the reviews!

@abitmore abitmore changed the title Managed Vesting Policy, plus Savings Account BSIP 57: Managed Vesting Policy, plus Savings Account Oct 8, 2019
@matle85
Copy link

matle85 commented Sep 10, 2020

Hi guys - sorry just trying to follow this...has it been incorporated / added...?

Could this functionality be used for 'yield farming' type activities? This is as per the current DeFi craze where people deposit a token and 'farm it' (receive a constant air drop of another token).

i.e. I create a new asset called CROP and agree that anyone who stakes BTS to me will receive CROP at a rate of 1 per hour (deposited every 5 mins or so). They can then withdraw the BTS or the CROP periodically.

Generally for yield farming the deposited funds are used to provide liquidity in uniswap/balancer but for us to do something like that we would need to be using the funds via DEXBot or something I guess which gets more complicated.

@sschiessl-bcp
Copy link
Collaborator Author

Hi guys - sorry just trying to follow this...has it been incorporated / added...?

Could this functionality be used for 'yield farming' type activities? This is as per the current DeFi craze where people deposit a token and 'farm it' (receive a constant air drop of another token).

i.e. I create a new asset called CROP and agree that anyone who stakes BTS to me will receive CROP at a rate of 1 per hour (deposited every 5 mins or so). They can then withdraw the BTS or the CROP periodically.

Generally for yield farming the deposited funds are used to provide liquidity in uniswap/balancer but for us to do something like that we would need to be using the funds via DEXBot or something I guess which gets more complicated.

Yes, that would be doable in the current design. And with some adjustment to speccs also fully automatic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants