Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSIP73: Match force-settlement orders with margin calls and limit orders #200

Merged
merged 6 commits into from Sep 14, 2019

Conversation

abitmore
Copy link
Member

PR for #181.

@abitmore abitmore changed the title Match force-settlement orders with margin calls and limit orders BSIP73: Match force-settlement orders with margin calls and limit orders Aug 26, 2019
Copy link
Contributor

@jmjatlanta jmjatlanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my "pedantic" mode was left on. The document is readable without any of the grammar changes I propose. Technically, this BSIP provides a clear picture of what is desired. Thanks!

I would happily mark this "approved" as-is, but would like to give others some time to review it.

bsip-0073.md Outdated Show resolved Hide resolved
bsip-0073.md Outdated Show resolved Hide resolved
bsip-0073.md Outdated Show resolved Hide resolved
bsip-0073.md Outdated Show resolved Hide resolved
bsip-0073.md Outdated Show resolved Hide resolved
bsip-0073.md Outdated Show resolved Hide resolved
bsip-0073.md Outdated Show resolved Hide resolved
bsip-0073.md Outdated Show resolved Hide resolved
bsip-0073.md Outdated Show resolved Hide resolved
bsip-0073.md Outdated Show resolved Hide resolved
bsip-0073.md Outdated Show resolved Hide resolved
bsip-0073.md Show resolved Hide resolved
bsip-0073.md Outdated Show resolved Hide resolved
bsip-0073.md Show resolved Hide resolved
pmconrad
pmconrad previously approved these changes Sep 11, 2019
@pmconrad
Copy link
Contributor

Thanks.
FTR, my approval only means that I think this BSIP meets formal requirements. I still think it does not add sufficient value to justify the cost (performance impact, more complicated market engine, implementation cost).

@abitmore
Copy link
Member Author

Thank you @pmconrad. The "Summary for Shareholders" section is still "TBD", I hope someone can help.

@pmconrad
Copy link
Contributor

Suggested summary:


When force-settling a SmartCoin, the user currently has to wait for the settlement delay before his tokens are exchanged for the collateral asset. This BSIP introduces a new flag that allows settlement requests to be matched with market orders during the waiting period, potentially resulting in faster settlement and a better price.

@abitmore
Copy link
Member Author

@pmconrad thanks. Please review again.

@ryanRfox ryanRfox merged commit 6c3c38e into master Sep 14, 2019
@sschiessl-bcp
Copy link
Collaborator

FTR, my approval only means that I think this BSIP meets formal requirements. I still think it does not add sufficient value to justify the cost (performance impact, more complicated market engine, implementation cost).

Should this be incorporated in the summary, or do we rather not burden the voters with this technical aspect?

@abitmore abitmore deleted the settle-order-changes branch September 30, 2019 18:46
@abitmore
Copy link
Member Author

abitmore commented Sep 30, 2019

FTR, my approval only means that I think this BSIP meets formal requirements. I still think it does not add sufficient value to justify the cost (performance impact, more complicated market engine, implementation cost).

Should this be incorporated in the summary, or do we rather not burden the voters with this technical aspect?

Create a PR please? Thanks. I'll do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants