Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging configs with nested lists #69

Closed
hogjosh opened this issue Apr 25, 2016 · 3 comments
Closed

Merging configs with nested lists #69

hogjosh opened this issue Apr 25, 2016 · 3 comments
Assignees

Comments

@hogjosh
Copy link

hogjosh commented Apr 25, 2016

I'm hesitant to consider this a bug outright, but I'll describe an example scenario.

If I create a release with 5 sublists defined for a particular key in prod.exs and need to deploy that release to a different environment where only 3 sublists are necessary (via a different .conf file), the merging process gives me the 3 sublists that I want, but also the last 2 from the initial prod.exs. I can see how a strict merge and a replacement of the list both make sense in various scenarios.

I seem to be fighting an uphill battle with sublists, so maybe I'm approaching the problem incorrectly, but figured I'd open it to discussion.

@bitwalker
Copy link
Owner

It may help to see a simplified example with all of the configs involved, but it sounds like it may be desirable to have a setting which toggles the merging behaviour for a specific configuration key correct?

@bitwalker
Copy link
Owner

ping :)

@bitwalker bitwalker self-assigned this Feb 3, 2017
@bitwalker
Copy link
Owner

Just FYI, in master, I've removed merging of nested lists, only keyword lists are merged, or unnested lists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants