Add support for the Nord Theme #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kspearrin
reviewed
Jul 21, 2019
| @@ -46,6 +46,7 @@ export class OptionsComponent implements OnInit { | |||
| { name: i18nService.t('default'), value: null }, | |||
| { name: i18nService.t('light'), value: 'light' }, | |||
| { name: i18nService.t('dark'), value: 'dark' }, | |||
| { name: i18nService.t('nord'), value: 'nord' }, | |||
There was a problem hiding this comment.
The name should just be hardcoded string "Nord" since there is no translation for it.
|
@kspearrin Hi Kyle. Thanks for reviewing my PR. I just implemented the code suggestion you made and added a preview to the PR |
addisonbeck
pushed a commit
that referenced
this pull request
May 5, 2022
eliykat
pushed a commit
that referenced
this pull request
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR maintains consistency across all the different products of Bitwarden (Desktop and Mobile apps) by adding support for the Nord theme.
Preview