Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Delete account" not accessible through keyboard navigation #3401

Closed
connorlanigan opened this issue Aug 28, 2022 · 1 comment · Fixed by #3406
Closed

"Delete account" not accessible through keyboard navigation #3401

connorlanigan opened this issue Aug 28, 2022 · 1 comment · Fixed by #3406
Labels
bug desktop Desktop Application

Comments

@connorlanigan
Copy link

Steps To Reproduce

  1. Go to the settings
  2. Using the Tab key, navigate to the item immediately before "Delete account" (currently "Unlock with PIN")
  3. Press the Tab key once more

Expected Result

The "Delete account" link is focused.

Actual Result

The focus skips the "Delete account" link, and the "PREFERENCES" section header is focused instead. The account can thus not be deleted without using a mouse.

Screenshots or Videos

screen recording of tabbing through the settings. the focus skips the "Delete account" item.

Additional Context

The "Delete account" text is currently an <a> element (without an href attribute). Since it does not act as a link, but rather opens a new modal, it could potentially be implemented as a <button> instead. This way it would automatically be focusable.

Operating System

Windows

Operating System Version

11

Installation method

Direct Download (from bitwarden.com)

Build Version

Version 2022.8.1

@patrickhlauke
Copy link
Contributor

nice catch. i hadn't even clocked that that was a control in its current form. filed #3406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug desktop Desktop Application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants