[PM-7175] Create vault settings component (navigational changes) #8840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move settings.component.ts to auth/popup/settings and rename to account-security.component.ts Move controls from settings.component.html and create account-security.component.html Move settings.component.html to tools/popup/settings.component.html Create settings.component.ts under tools/popup/settings Fixup module imports and routing Add new strings to en/message.json
Move controls from settings.component.html to vault-settings.component.html Register VaultSettingsComponent within app.module Register route for VaultSettingsComponent Add new string in en/messages.json
…s/pm-7175/create-vault-settings-component
…s/pm-7172/create-account-security-settings-component
…t' of https://github.com/bitwarden/clients into tools/pm-7175/create-vault-settings-component
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8840 +/- ##
==========================================
+ Coverage 27.75% 27.77% +0.02%
==========================================
Files 2419 2420 +1
Lines 69915 69851 -64
Branches 13013 12980 -33
==========================================
- Hits 19402 19399 -3
+ Misses 49012 48953 -59
+ Partials 1501 1499 -2 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
audrey-jensen
previously approved these changes
Apr 22, 2024
…t' of https://github.com/bitwarden/clients into tools/pm-7175/create-vault-settings-component
shane-melton
previously approved these changes
Apr 25, 2024
apps/browser/src/vault/popup/settings/vault-settings.component.ts
Outdated
Show resolved
Hide resolved
…s/pm-7172/create-account-security-settings-component
…t' of https://github.com/bitwarden/clients into tools/pm-7175/create-vault-settings-component
Base automatically changed from
tools/pm-7172/create-account-security-settings-component
to
main
May 7, 2024 20:23
djsmith85
dismissed stale reviews from shane-melton and audrey-jensen
The base branch was changed.
…s/pm-7175/create-vault-settings-component
shane-melton
approved these changes
May 7, 2024
audrey-jensen
approved these changes
May 7, 2024
djsmith85
added a commit
that referenced
this pull request
May 17, 2024
Some left-over clean-up from #8840 - Removing import and export methods
djsmith85
added a commit
that referenced
this pull request
May 22, 2024
#9233) * Move help-and-feedback to tools and rename to about-page Moved help-and-feedback.component to ..tools Renamed it to about-page Changed the title to about Changed the settings button to about Updated routes Updates transition animation * Move button to open AboutDialog from settings to about-page * Move launch web-vault to about-page * Move rate extension from settings to about-page * Fix no-floating-promises * Remove icons from about-page entries * Make about-page standalone * Create MoreFromBitwardenPage component Create new component Add button to navigate to new component from about-page Add routing for new component * Add new speedbumps to help-center and web-app links * Add link to Bitwarden Authenticator page Include speedbump explaing some functionality about the the authenticator * Add link to Secrets Manager page Include speedbump explaining some functionality of Secrets Manager * Add link to Passwordless.dev page Include speedbump explaining some functionality of Passwordless.dev * Move learnFromOrg over to more-from-bitwarden Include speedbump that explains Bitwarden for business * Clean-up settings.component Some left-over clean-up from #8840 - Removing import and export methods * Move premium-link to more-from-bitwarden Hide link if user already has premium * Add popout-button to about-page * Remove unneeded headings * Move popout-button on setting to the right * Add Free Bitwarden Families link Include speedbump explaining Free Bitwarden Families --------- Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Split out the vault-settings related controls into a separate page according to the UI re-design (navigational changes)
This only contains navigational changes and makes it easier to enable code-ownership
settings.component is under tools-ownership
and
vault-settings.component, folder.component and sync.component are under vault-ownership
The visual changes planned for the UI refresh will be done, once all needed base components from the Component Library are available.
Code changes
Screenshots
Before
After
Before you submit