Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-7175] Create vault settings component (navigational changes) #8840

Merged
merged 21 commits into from
May 7, 2024
Merged

[PM-7175] Create vault settings component (navigational changes) #8840

merged 21 commits into from
May 7, 2024

Commits on Apr 18, 2024

  1. Move about.component into tools ownership

    @djsmith85
    djsmith85 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    ae15023 View commit details
    Browse the repository at this point in the history

  2. Split out account security settings 

    Move settings.component.ts to auth/popup/settings and rename to account-security.component.ts
Move controls from settings.component.html and create account-security.component.html
Move settings.component.html to tools/popup/settings.component.html
Create settings.component.ts under tools/popup/settings
Fixup module imports and routing
Add new strings to en/message.json
    @djsmith85
    djsmith85 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    83c4637 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into tools/pm-7172/create-account-security-settin… 

    …gs-component
    @djsmith85
    djsmith85 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    ab93433 View commit details
    Browse the repository at this point in the history

  4. Move vault-timeout-input.component to auth

    @djsmith85
    djsmith85 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    b83b038 View commit details
    Browse the repository at this point in the history

  5. Move await-desktop-dialog.component to auth

    @djsmith85
    djsmith85 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    eb03946 View commit details
    Browse the repository at this point in the history

  6. Move folder.component to vault/popup/settings

    @djsmith85
    djsmith85 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    0cd9cd8 View commit details
    Browse the repository at this point in the history

  7. Move sync.component to vault/popup/settings

    @djsmith85
    djsmith85 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    d71cc94 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Create vault settings component 

    Move controls from settings.component.html to vault-settings.component.html
Register VaultSettingsComponent within app.module
Register route for VaultSettingsComponent
Add new string in en/messages.json
    @djsmith85
    djsmith85 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    1f38dcb View commit details
    Browse the repository at this point in the history

  2. Fix routing for back navigation on child pages of vault settings

    @djsmith85
    djsmith85 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    c684418 View commit details
    Browse the repository at this point in the history

  3. Add transitions to vault-settings sub-pages

    @djsmith85
    djsmith85 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    c486d71 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of https://github.com/bitwarden/clients into tool… 

    …s/pm-7175/create-vault-settings-component
    @djsmith85
    djsmith85 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    2003dde View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of https://github.com/bitwarden/clients into tool… 

    …s/pm-7172/create-account-security-settings-component
    @djsmith85
    djsmith85 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    9d99efa View commit details
    Browse the repository at this point in the history

  6. Add transition for account-security

    @djsmith85
    djsmith85 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    362fb8e View commit details
    Browse the repository at this point in the history

  7. Merge branch 'tools/pm-7172/create-account-security-settings-componen… 

    …t' of https://github.com/bitwarden/clients into tools/pm-7175/create-vault-settings-component
    @djsmith85
    djsmith85 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    e0a4a30 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Merge branch 'main' into tools/pm-7172/create-account-security-settin… 

    …gs-component
    @djsmith85
    djsmith85 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    0ed6fb4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'tools/pm-7172/create-account-security-settings-componen… 

    …t' of https://github.com/bitwarden/clients into tools/pm-7175/create-vault-settings-component
    @djsmith85
    djsmith85 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    feca6c9 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Add an await to popping out the extension

    @djsmith85
    djsmith85 committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    46c0ffc View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Use "Vault" instead of "Vault settings" as title

    @djsmith85
    djsmith85 committed May 6, 2024
    Configuration menu
    Copy the full SHA
    1d8736d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/bitwarden/clients into tool… 

    …s/pm-7172/create-account-security-settings-component
    @djsmith85
    djsmith85 committed May 6, 2024
    Configuration menu
    Copy the full SHA
    7398990 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Merge branch 'tools/pm-7172/create-account-security-settings-componen… 

    …t' of https://github.com/bitwarden/clients into tools/pm-7175/create-vault-settings-component
    @djsmith85
    djsmith85 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    4df0eba View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/bitwarden/clients into tool… 

    …s/pm-7175/create-vault-settings-component
    @djsmith85
    djsmith85 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    899188c View commit details
    Browse the repository at this point in the history