Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7175] Create vault settings component (navigational changes) #8840

Merged
merged 21 commits into from
May 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
ae15023
Move about.component into tools ownership
djsmith85 Apr 18, 2024
83c4637
Split out account security settings
djsmith85 Apr 18, 2024
ab93433
Merge branch 'main' into tools/pm-7172/create-account-security-settin…
djsmith85 Apr 18, 2024
b83b038
Move vault-timeout-input.component to auth
djsmith85 Apr 18, 2024
eb03946
Move await-desktop-dialog.component to auth
djsmith85 Apr 18, 2024
0cd9cd8
Move folder.component to vault/popup/settings
djsmith85 Apr 18, 2024
d71cc94
Move sync.component to vault/popup/settings
djsmith85 Apr 18, 2024
1f38dcb
Create vault settings component
djsmith85 Apr 19, 2024
c684418
Fix routing for back navigation on child pages of vault settings
djsmith85 Apr 19, 2024
c486d71
Add transitions to vault-settings sub-pages
djsmith85 Apr 19, 2024
2003dde
Merge branch 'main' of https://github.com/bitwarden/clients into tool…
djsmith85 Apr 19, 2024
9d99efa
Merge branch 'main' of https://github.com/bitwarden/clients into tool…
djsmith85 Apr 19, 2024
362fb8e
Add transition for account-security
djsmith85 Apr 19, 2024
e0a4a30
Merge branch 'tools/pm-7172/create-account-security-settings-componen…
djsmith85 Apr 19, 2024
0ed6fb4
Merge branch 'main' into tools/pm-7172/create-account-security-settin…
djsmith85 Apr 22, 2024
feca6c9
Merge branch 'tools/pm-7172/create-account-security-settings-componen…
djsmith85 Apr 22, 2024
46c0ffc
Add an await to popping out the extension
djsmith85 Apr 25, 2024
1d8736d
Use "Vault" instead of "Vault settings" as title
djsmith85 May 6, 2024
7398990
Merge branch 'main' of https://github.com/bitwarden/clients into tool…
djsmith85 May 6, 2024
4df0eba
Merge branch 'tools/pm-7172/create-account-security-settings-componen…
djsmith85 May 7, 2024
899188c
Merge branch 'main' of https://github.com/bitwarden/clients into tool…
djsmith85 May 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions apps/browser/src/popup/app-routing.animations.ts
Original file line number Diff line number Diff line change
Expand Up @@ -177,20 +177,24 @@ export const routerTransition = trigger("routerTransition", [
transition("tabs => account-security", inSlideLeft),
transition("account-security => tabs", outSlideRight),

transition("tabs => import", inSlideLeft),
transition("import => tabs", outSlideRight),
// Vault settings
transition("tabs => vault-settings", inSlideLeft),
transition("vault-settings => tabs", outSlideRight),

transition("tabs => export", inSlideLeft),
transition("export => tabs", outSlideRight),
transition("vault-settings => import", inSlideLeft),
transition("import => vault-settings", outSlideRight),

transition("tabs => folders", inSlideLeft),
transition("folders => tabs", outSlideRight),
transition("vault-settings => export", inSlideLeft),
transition("export => vault-settings", outSlideRight),

transition("vault-settings => folders", inSlideLeft),
transition("folders => vault-settings", outSlideRight),

transition("folders => edit-folder, folders => add-folder", inSlideUp),
transition("edit-folder => folders, add-folder => folders", outSlideDown),

transition("tabs => sync", inSlideLeft),
transition("sync => tabs", outSlideRight),
transition("vault-settings => sync", inSlideLeft),
transition("sync => vault-settings", outSlideRight),

transition("tabs => excluded-domains", inSlideLeft),
transition("excluded-domains => tabs", outSlideRight),
Expand Down
11 changes: 9 additions & 2 deletions apps/browser/src/popup/app-routing.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,15 @@ import { VaultFilterComponent } from "../vault/popup/components/vault/vault-filt
import { VaultItemsComponent } from "../vault/popup/components/vault/vault-items.component";
import { ViewComponent } from "../vault/popup/components/vault/view.component";
import { FolderAddEditComponent } from "../vault/popup/settings/folder-add-edit.component";
import { FoldersComponent } from "../vault/popup/settings/folders.component";
import { SyncComponent } from "../vault/popup/settings/sync.component";
import { VaultSettingsComponent } from "../vault/popup/settings/vault-settings.component";

import { extensionRefreshRedirect, extensionRefreshSwap } from "./extension-refresh-route-utils";
import { debounceNavigationGuard } from "./services/debounce-navigation.service";
import { ExcludedDomainsComponent } from "./settings/excluded-domains.component";
import { FoldersComponent } from "./settings/folders.component";
import { HelpAndFeedbackComponent } from "./settings/help-and-feedback.component";
import { OptionsComponent } from "./settings/options.component";
import { SyncComponent } from "./settings/sync.component";
import { TabsV2Component } from "./tabs-v2.component";
import { TabsComponent } from "./tabs.component";

Expand Down Expand Up @@ -253,6 +254,12 @@ const routes: Routes = [
canActivate: [AuthGuard],
data: { state: "account-security" },
},
{
path: "vault-settings",
component: VaultSettingsComponent,
canActivate: [AuthGuard],
data: { state: "vault-settings" },
},
{
path: "folders",
component: FoldersComponent,
Expand Down
6 changes: 4 additions & 2 deletions apps/browser/src/popup/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,17 +70,18 @@ import { VaultSelectComponent } from "../vault/popup/components/vault/vault-sele
import { ViewCustomFieldsComponent } from "../vault/popup/components/vault/view-custom-fields.component";
import { ViewComponent } from "../vault/popup/components/vault/view.component";
import { FolderAddEditComponent } from "../vault/popup/settings/folder-add-edit.component";
import { FoldersComponent } from "../vault/popup/settings/folders.component";
import { SyncComponent } from "../vault/popup/settings/sync.component";
import { VaultSettingsComponent } from "../vault/popup/settings/vault-settings.component";

import { AppRoutingModule } from "./app-routing.module";
import { AppComponent } from "./app.component";
import { PopOutComponent } from "./components/pop-out.component";
import { UserVerificationComponent } from "./components/user-verification.component";
import { ServicesModule } from "./services/services.module";
import { ExcludedDomainsComponent } from "./settings/excluded-domains.component";
import { FoldersComponent } from "./settings/folders.component";
import { HelpAndFeedbackComponent } from "./settings/help-and-feedback.component";
import { OptionsComponent } from "./settings/options.component";
import { SyncComponent } from "./settings/sync.component";
import { TabsV2Component } from "./tabs-v2.component";
import { TabsComponent } from "./tabs.component";

Expand Down Expand Up @@ -159,6 +160,7 @@ import "../platform/popup/locales";
SetPasswordComponent,
AccountSecurityComponent,
SettingsComponent,
VaultSettingsComponent,
ShareComponent,
SsoComponent,
SyncComponent,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<form (ngSubmit)="submit()" [formGroup]="exportForm">
<header>
<div class="left">
<button type="button" routerLink="/tabs/settings">
<button type="button" routerLink="/vault-settings">
<span class="header-icon" aria-hidden="true"><i class="bwi bwi-angle-left"></i></span>
<span>{{ "back" | i18n }}</span>
</button>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<header>
<div class="left">
<button type="button" routerLink="/tabs/settings">
<button type="button" routerLink="/vault-settings">
<span class="header-icon" aria-hidden="true"><i class="bwi bwi-angle-left"></i></span>
<span>{{ "back" | i18n }}</span>
</button>
Expand Down
33 changes: 2 additions & 31 deletions apps/browser/src/tools/popup/settings/settings.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -30,17 +30,9 @@ <h2 class="box-header">{{ "manage" | i18n }}</h2>
<button
type="button"
class="box-content-row box-content-row-flex text-default"
routerLink="/folders"
routerLink="/vault-settings"
>
<div class="row-main">{{ "folders" | i18n }}</div>
<i class="bwi bwi-angle-right bwi-lg row-sub-icon" aria-hidden="true"></i>
</button>
<button
type="button"
class="box-content-row box-content-row-flex text-default"
routerLink="/sync"
>
<div class="row-main">{{ "sync" | i18n }}</div>
<div class="row-main">{{ "vault" | i18n }}</div>
<i class="bwi bwi-angle-right bwi-lg row-sub-icon" aria-hidden="true"></i>
</button>
<button
Expand Down Expand Up @@ -72,27 +64,6 @@ <h2 class="box-header">{{ "account" | i18n }}</h2>
<div class="box list">
<h2 class="box-header">{{ "tools" | i18n }}</h2>
<div class="box-content single-line">
<button
type="button"
class="box-content-row box-content-row-flex text-default"
appStopClick
(click)="import()"
>
<div class="row-main">{{ "importItems" | i18n }}</div>
<i
class="bwi bwi-external-link bwi-lg row-sub-icon bwi-rotate-270 bwi-fw"
aria-hidden="true"
></i>
</button>
<button
type="button"
class="box-content-row box-content-row-flex text-default"
appStopClick
(click)="export()"
>
<div class="row-main">{{ "exportVault" | i18n }}</div>
<i class="bwi bwi-angle-right bwi-lg row-sub-icon" aria-hidden="true"></i>
</button>
<button
type="button"
class="box-content-row box-content-row-flex text-default"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<header>
<div class="left">
<button type="button" routerLink="/tabs/settings">
<button type="button" routerLink="/vault-settings">
<span class="header-icon"><i class="bwi bwi-angle-left" aria-hidden="true"></i></span>
<span>{{ "back" | i18n }}</span>
</button>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<header>
<div class="left">
<button type="button" routerLink="/tabs/settings">
<button type="button" routerLink="/vault-settings">
<span class="header-icon"><i class="bwi bwi-angle-left" aria-hidden="true"></i></span>
<span>{{ "back" | i18n }}</span>
</button>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
<app-header>
<div class="left">
<button type="button" routerLink="/tabs/settings">
<span class="header-icon"><i class="bwi bwi-angle-left" aria-hidden="true"></i></span>
<span>{{ "back" | i18n }}</span>
</button>
</div>
<h1 class="center">
<span class="title">{{ "vault" | i18n }}</span>
</h1>
<div class="right">
<app-pop-out></app-pop-out>
</div>
</app-header>
<main tabindex="-1">
<div class="box list">
<div class="box-content single-line">
<button
type="button"
class="box-content-row box-content-row-flex text-default"
routerLink="/folders"
>
<div class="row-main">{{ "folders" | i18n }}</div>
<i class="bwi bwi-angle-right bwi-lg row-sub-icon" aria-hidden="true"></i>
</button>
<button
type="button"
class="box-content-row box-content-row-flex text-default"
appStopClick
(click)="import()"
>
<div class="row-main">{{ "importItems" | i18n }}</div>
<i
class="bwi bwi-external-link bwi-lg row-sub-icon bwi-rotate-270 bwi-fw"
aria-hidden="true"
></i>
</button>
<button
type="button"
class="box-content-row box-content-row-flex text-default"
routerLink="/export"
>
<div class="row-main">{{ "exportVault" | i18n }}</div>
<i class="bwi bwi-angle-right bwi-lg row-sub-icon" aria-hidden="true"></i>
</button>
<button
type="button"
class="box-content-row box-content-row-flex text-default"
routerLink="/sync"
>
<div class="row-main">{{ "sync" | i18n }}</div>
<i class="bwi bwi-angle-right bwi-lg row-sub-icon" aria-hidden="true"></i>
</button>
</div>
</div>
</main>
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import { Component } from "@angular/core";
import { Router } from "@angular/router";

import { MessagingService } from "@bitwarden/common/platform/abstractions/messaging.service";

import { BrowserApi } from "../../../platform/browser/browser-api";
import BrowserPopupUtils from "../../../platform/popup/browser-popup-utils";

@Component({
selector: "vault-settings",
templateUrl: "vault-settings.component.html",
})
export class VaultSettingsComponent {
constructor(
public messagingService: MessagingService,
private router: Router,
) {}

async import() {
await this.router.navigate(["/import"]);
if (await BrowserApi.isPopupOpen()) {
await BrowserPopupUtils.openCurrentPagePopout(window);
}
}
}
Loading