[Bug] spurious orphans when doubling

[feefladder]

So, when having a class like this:

extends Node
class_name IMakeOrphans

var node = Node.new()

func _ready():
#     node = Node.new()
    add_child(node)

and double it, I get orphan messages:

extends GutTest

func test_no_orphans():
    add_child_autofree(IMakeOrphans.new())
    pass_test("should have no orphans")

func test_orphans():
    add_child_autoqfree(double(IMakeOrphans).new())
    pass_test("should have an orphan")

func test_orphans_partial():
    add_child_autoqfree(partial_double(IMakeOrphans).new())
    pass_test("should also have an orphan")

makes 2 orphans.

However, if the class would be like this:

extends Node
class_name IMakeOrphans

var node: Node

func _ready():
    node = Node.new()
    add_child(node)

no orhpans are created.

Not sure what causes it, but I think the script is run once when doubling?

[bitwes]

The script is run once. You can add:

func _notification(what):
	if(what == NOTIFICATION_PREDELETE):
		<free things here if they exist>

so that any nodes you have created are deleted when not in the tree.

[bitwes]

Reopen if the last comment did not address the issue.