Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godot 4 GUT Panel Issues #459

Closed
19 of 20 tasks
bitwes opened this issue Feb 23, 2023 · 2 comments
Closed
19 of 20 tasks

Godot 4 GUT Panel Issues #459

bitwes opened this issue Feb 23, 2023 · 2 comments
Labels
Godot 4.0 Issues related to Godot 4.0

Comments

@bitwes
Copy link
Owner

bitwes commented Feb 23, 2023

The panel is 80% working now. There's still some bugs/polish needed but you can run the suite/script/inner-class/single-test and the Results Tree is now working as it should.

General

  • Running based on cursor position is broke currently
  • Sync clicks toggle for Text box and script does not appear to work
  • Setting Runner Font not working.
  • None of the tooltips appear to be showing.

Shortcuts

  • Keyboard Shortcuts cannot be set.
  • Shortcuts dialog is tiny at first, should not be resizable.

Settings

  • Post-Run and Pre-Run Hook open file buttons don't work
  • Settings panel is tiny, should have a minimum size when shown.

Output Panel

  • Cannot copy Output Text.
  • Text output search does not work.
  • Syntax highlighting toggle for the Text Output is reversed.
  • Setting font for Output text not working.
  • Setting font size for Output text not working.
  • Text colors needs some work.

Results Tree

  • Script entry should include counts of all Inner Classes.
  • Results should only include Inner Classes that were run.
  • Clicking on method names in the Test Result Tree takes you to the top of the file.
  • Green indicator for Test Result Tree is missing
  • Including passed tests toggle takes 3 clicks to enable.
  • Clicking on a test (and probably a inner class) for a file that is not open will take you to the top of the file in the editor. If you click an assert with a line number then it will go to the line. Once the file is open, clicking on nodes in the tree acts normally. This is a strong indicator that an await is probably needed between opening the file and searching for text. Especially since an assert with a line number always works.
@mbrealm
Copy link
Contributor

mbrealm commented Feb 25, 2023

This is very encouraging - thanks for your work on it!

After previously removing GUT from my v4 project experimental port, I will re-add it and see if I can get back to running tests!

@bitwes
Copy link
Owner Author

bitwes commented May 24, 2023

All the items are now implemented.

@bitwes bitwes closed this as completed May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Godot 4.0 Issues related to Godot 4.0
Projects
None yet
Development

No branches or pull requests

2 participants