-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exactly match upstream dropbox library's functionality and algorithms #32
Conversation
The other files in upstream's data-scripts dir are used to generate data/*.txt, which we should just copy when they update them. These files are used (in upstream) to build src/adjacency_graphs.coffee and src/frequency_lists.coffee, and will be modified in the PHP port to instead build src/Matchers/frequency_lists.json and src/Matchers/adjacency_graphs.json
adjacency_graphs.json is unmodified. Frequency_lists.json now contains additional datasets
…ffeescript implementation
…lder versions of PHP
It's impossible for us to match all browsers exactly (since the way that elements that compare as equal as sorted is implementation-defined in JavaScript), but this gets us pretty close.
This works around a PHP 5.5 issue
Match upstream
# Conflicts: # .travis.yml # composer.json # composer.lock # src/Matcher.php # src/Matchers/Bruteforce.php # src/Matchers/DateMatch.php # src/Matchers/DictionaryMatch.php # src/Matchers/DigitMatch.php # src/Matchers/L33tMatch.php # src/Matchers/Match.php # src/Matchers/MatchInterface.php # src/Matchers/RepeatMatch.php # src/Matchers/SequenceMatch.php # src/Matchers/SpatialMatch.php # src/Matchers/YearMatch.php # src/Scorer.php # src/ScorerInterface.php # src/Searcher.php # src/Zxcvbn.php # test/MatcherTest.php # test/Matchers/BruteforceTest.php # test/Matchers/DateTest.php # test/Matchers/DictionaryTest.php # test/Matchers/DigitTest.php # test/Matchers/L33tTest.php # test/Matchers/RepeatTest.php # test/Matchers/SequenceTest.php # test/Matchers/SpatialTest.php # test/Matchers/YearTest.php # test/ScorerTest.php # test/SearcherTest.php # test/ZxcvbnTest.php
Any progress on getting this merged in? |
…tion for public release
Use my own package name in preparation for public release
This PR has now been open for 6 weeks, and active work on the branch has been going on since March. I've gone ahead and published my fork on packagist - https://packagist.org/packages/mkopinsky/zxcvbn-php |
Actually, these commits in this PR are very huge. It should clear them and I don't think other people commits should include in this PR :). |
The amount of changes indeed is huge, but that's what was necessary to exactly match the upstream js library. |
Hi @mkopinsky, thank you for your reply. I think this PR should be cleaned up the commits and squashed all commits to one commit. In general, the repository owner doesn't want to merge a PR with the large commits :-). |
The issue with this PR (in my mind) isn't the number of commits but the number of changes. If @bjeavons says that he'd prefer me to squash commits, I'd be happy to do so. |
Hi @mkopinsky. Ok. Thank you for answer and just wait for the repository author. |
Hey, can @bjeavons please take a look and answer? I'm using the library and I'd really like to be able to update my app so that the PHP side matches the JS. |
@bjeavons has indicated that he doesn't intend on merging this. If you want your PHP side to match the JS, switch to mkopinsky/zxcvbn-php in your composer.json |
@mkopinsky It's a shame that he didn't want to merge it, but I'm glad I can just update to your repo. EDIT: Also, just switched to your repo, and it works like a charm. 😊 |
Addresses #15