Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Local cache #208

Closed
Shomnipotence opened this issue Jun 6, 2024 · 3 comments
Closed

[Proposal] Local cache #208

Shomnipotence opened this issue Jun 6, 2024 · 3 comments
Labels
wontfix This will not be worked on

Comments

@Shomnipotence
Copy link

Describe the solution you'd like
The mailing list must be re-fetched on every startup. The mailing list should be cached, then fetched on startup, compared with the current content, and dynamically loaded when new content is available.

@Shomnipotence Shomnipotence added the enhancement New feature or request label Jun 6, 2024
@Tiktack
Copy link
Collaborator

Tiktack commented Jun 6, 2024

What do you mean re-fetched? Yes, every time you open mail list it queries Sqlite DB. Local DB very fast ( for UI it won't be noticeable it's from memory or from cache). Also, if you are using store version, I believe it lists a lot of emails, beta version lists only 20 items on initial render.
Also, some slowness comes from setting that enables threads, but in beta version for outlook/gmail threading strategy performance was also improved ( by reducing number of queries and small local cache that lives for one request)

Cache just sounds easy and cool, but in practice it adds a lot of complexity to implement it properly to avoid bugs. Right now I don't see any reason to add it.

@bkaankose what do you think?

@bkaankose
Copy link
Owner

I am completely against the caching personally. I see some benefits, but managing cache in this environment will just be complete mess. I don't think the burden it brings is bigger than the benefit at this point.

Mail initialization is already very fast. Thanks to @Tiktack's improvement on #173 it's already faster. I don't see a benefit in caching at the moment.

@bkaankose
Copy link
Owner

This will not be worked on. Closing the issue.

@bkaankose bkaankose added wontfix This will not be worked on and removed enhancement New feature or request labels Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants