Small fix on soname defining on ldflags for Android examples. #3184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… can dynamically resolve the library location from known locations (as opposed to a hard coded location often residing on the host cross compiling filesystem. linked issue is, bkaradzic#2176
bkaradzic
requested changes
Oct 16, 2023
scripts/genie.lua
Outdated
| links { | ||
| "EGL", | ||
| "GLESv2", | ||
| } | ||
|
|
||
| configuration { "android*", "Debug" } | ||
| linkoptions { | ||
| "-shared -Wl,-soname,lib" .. project().name .. "Debug.so" |
There was a problem hiding this comment.
You should keep this separate.
Leave linkoptions { "-shared" } above, and add these new options without it below.
… and add the additional linker flags for each Debug/Release configuration.
jay3d
pushed a commit
to jay3d/bgfx
that referenced
this pull request
Dec 7, 2023
…zic#3184) * Add linker options to add SONAME to the linked target so Android apps can dynamically resolve the library location from known locations (as opposed to a hard coded location often residing on the host cross compiling filesystem. linked issue is, bkaradzic#2176 * Kepp orginal code for linkoptions in the previous configuration block and add the additional linker flags for each Debug/Release configuration. * Add comma character to EOL to match orginal code.
mipek
pushed a commit
to mipek/bgfx
that referenced
this pull request
Mar 2, 2024
…zic#3184) * Add linker options to add SONAME to the linked target so Android apps can dynamically resolve the library location from known locations (as opposed to a hard coded location often residing on the host cross compiling filesystem. linked issue is, bkaradzic#2176 * Kepp orginal code for linkoptions in the previous configuration block and add the additional linker flags for each Debug/Release configuration. * Add comma character to EOL to match orginal code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue for this PR is tracked here,
#3183
This PR adds the correct SONAME for the target dynamic libraries for Android so the dynamic linker can search the default paths for shared libraries instead of a fixed path.
Below is the output from readelf showing correct embedding of SONAME.